Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

gkhanna79
Copy link
Member

@dagood
Copy link
Member

dagood commented Sep 21, 2016

Not marking them as stable means they'll end up as 1.0.5-servicing-*, right? I believe that's what we want, but want to make sure.

@gkhanna79
Copy link
Member Author

gkhanna79 commented Sep 21, 2016

Correct - that is what we want for now until we have the next release and attempt to stabilize them.

@gkhanna79 gkhanna79 added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 21, 2016
@gkhanna79
Copy link
Member Author

@dotnet-bot test Ubuntu x64 Checked Build and Test please

@gkhanna79
Copy link
Member Author

@gkhanna79
Copy link
Member Author

@weshaggard PTAL

@weshaggard
Copy link
Member

LGTM.

If the goal is for these to all share the same version, can I suggest that we put it in common props file and use that property in each of these pkgproj's? That will make future updates easier and less error prone.

@gkhanna79
Copy link
Member Author

Same version is by default right now though components could choose not to have it. Either way, I will make that change in master and not here.

@gkhanna79 gkhanna79 merged commit 082421a into dotnet:release/1.0.0 Sep 28, 2016
@karelz karelz modified the milestone: 1.0.x Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

* NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants