This repository was archived by the owner on Jan 23, 2023. It is now read-only.
System.GC.HeapHardLimit and .HeapHardLimitPercent in runtimeconfig.json #25574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new configuration options, "System.GC.HeapHardLimit" and "System.GC.HeapHardLimitPercent" to runtimeconfig.json. These behave the same as COMPlus_GCHeapHardLimit and COMPlus_GCHeapHardLimitPercent.
ghost
mentioned this pull request
Maoni0
reviewed
Jul 6, 2019
src/vm/eeconfig.cpp
Outdated
| if (!iGCgen0size) iGCgen0size = GetConfigDWORD_DontUse_(CLRConfig::UNSUPPORTED_GCgen0size, iGCgen0size); | ||
| #endif //_WIN64 | ||
|
|
||
| iGCHeapHardLimit = Configuration::GetKnobULONGLONGValue(W("System.GC.HeapHardLimit")); |
There was a problem hiding this comment.
Configuration::GetKnobULONGLONGValue [](start = 22, length = 37)
this will need to be cast to (size_t)
|
other than the one minor comment I have above this LGTM |
Maoni0
approved these changes
Jul 8, 2019
ghost
requested a review
from 
MeiChin-Tsai
approved these changes
Jul 8, 2019
ghost
mentioned this pull request
Merged
ghost
mentioned this pull request
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…on (dotnet/coreclr#25574) * System.GC.HeapHardLimit and .HeapHardLimitPercent in runtimeconfig.json This adds two new configuration options, "System.GC.HeapHardLimit" and "System.GC.HeapHardLimitPercent" to runtimeconfig.json. These behave the same as COMPlus_GCHeapHardLimit and COMPlus_GCHeapHardLimitPercent. * Add cast * Dummy change to trigger tests rerun Commit migrated from dotnet/coreclr@9227bd5
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new configuration options, "System.GC.HeapHardLimit" and
"System.GC.HeapHardLimitPercent" to runtimeconfig.json. These behave the
same as COMPlus_GCHeapHardLimit and COMPlus_GCHeapHardLimitPercent.
I tested this change by manually debugging into
EEConfig::sync,GCToEEInterface::GetIntConfigValue, andGCHeap::Initialize.