Add GC.GetConfigVariable API, and support more GC settings in runtimeconfig #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config Currently, a few GC settings are only available as environment variables. This adds support for a few more as runtimeconfig settings. They are: * "System.GC.CpuGroup": Same as `COMPlus_GCCpuGroup` * "System.GC.HighMemoryPercent": Same as `COMPlus_GCHighMemPercent` * "System.GC.LargePages": Same as `COMPlus_GCLargePages` * "System.GC.HeapAffinitizeRnages": Same as `COMPlus_GCHeapAffinitizeRanges` This is similar to dotnet/coreclr#25574, which did this for "System.GC.HeapHardLimit" and "System.GC.HeapHardLimitPercent". This PR also adds a new API described in dotnet/corefx#42499 .
ghost
requested review from
|
Have the associated APIs been approved yet? |
|
Not yet. Presume this should be tagged |
We generally avoid putting up PRs at all for APIs that haven't been approved. If the goal is just to get feedback as part of the issue discussion, or to sure the progress you've made, that can be done by just linking to the relevant commit in your fork from the relevant issues. Thanks |
ghost
closed this
|
cc: @terrajobst |
ghost
locked as resolved and limited conversation to collaborators
radical
pushed a commit
to radical/runtime
that referenced
this pull request
Jul 7, 2022
I guess this is thanks to the sudo launchctl we are doing. However, I won't waste energy on finding the cause and will just fix this symptom since we will move to Arcade soon. Fixes: dotnet#162 Fixes: dotnet#117
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a few GC settings are only available as environment variables.
This adds support for a few more as runtimeconfig settings.
They are:
COMPlus_GCCpuGroupCOMPlus_GCHighMemPercentCOMPlus_GCLargePagesCOMPlus_GCHeapAffinitizeRangesThis is similar to dotnet/coreclr#25574,
which did this for "System.GC.HeapHardLimit" and "System.GC.HeapHardLimitPercent".
This PR also adds a new API described in dotnet/corefx#42499 .