This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port to release/1.0.0: Fix PAL executable allocator locking #5771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call the ExecutableAllocator from two places in PAL. One is the VirtualAlloc when the allocation type contains MEM_RESERVE_EXECUTABLE. The other is MAPMapPEFile. While the former is called inside of the virtual_critsec critical section, the latter doesn't take that critical section and so in some race cases, we were returning the same address twice - once for VirtualAlloc and once for MAPMapPEFile. That resulted in strange memory corruption cases. The fix is to use the same critical section for the MAPMapPEFile too. I am also reverting the change in the virtual commit that was made when we have thought that the culprit might be in the mprotect.
|
Cool! @sergiy-k Did you get a chance to run this locally where you could reproduce the problem? |
|
No, not yet. I'm building it right now. |
|
@dotnet-bot test Ubuntu Checked pri1r2r please |
|
@dotnet-bot test OSX Checked pri1r2r please |
|
@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please |
|
The results for Ubuntu R2R tests look OK. There is one failure due to a known issue (https://github.com/dotnet/coreclr/issues/5501). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call the ExecutableAllocator from two places in PAL. One is the
VirtualAlloc when the allocation type contains MEM_RESERVE_EXECUTABLE.
The other is MAPMapPEFile.
While the former is called inside of the virtual_critsec critical section,
the latter doesn't take that critical section and so in some race cases,
we were returning the same address twice - once for VirtualAlloc and
once for MAPMapPEFile. That resulted in strange memory corruption cases.
The fix is to use the same critical section for the MAPMapPEFile too.
I am also reverting the change in the virtual commit that was made when
we have thought that the culprit might be in the mprotect.