[3.1] Credscan second round

[aik-jahoda]

Second round of Credscan effort

First we need merge dotnet/runtime-assets#124

[danmoseley]

LGTM if tests pass with the updated cert files.

[SamMonoRT]

@aik-jahoda - like the last set of changes, are these going to be ported over to mono\corefx ?

[Anipik]

Branches got closed yesterday, we might have to wait for the may release to merge this one.

[danmoseley]

@SamMonoRT for speed, is it possible for someone on your team to cherry-pick them?

Edit: I mean, I'm sure he would be happy to. I'm just trying to reduce the critical path...

[danmoseley]

Process terminated. Assertion Failed
Certificates cctor threw System.IO.DirectoryNotFoundException: Could not find a part of the path '/root/helix/work/workitem/TestDataCertificates/testservereku.contoso.com.pfx'.
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func`2 errorRewriter) in /_/src/System.Private.CoreLib/shared/Interop/Unix/Interop.IOErrors.cs:line 24
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode) in /_/src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs:line 39
   at System.IO.FileStream.OpenHandle(FileMode mode, FileShare share, FileOptions options) in /_/src/System.Private.CoreLib/shared/System/IO/FileStream.Unix.cs:line 61
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options) in /_/src/System.Private.CoreLib/shared/System/IO/FileStream.cs:line 237

Rerunning - hopefully certs have flowed now.

[SamMonoRT]

@SamMonoRT for speed, is it possible for someone on your team to cherry-pick them?

Edit: I mean, I'm sure he would be happy to. I'm just trying to reduce the critical path...

Yes, that's a possibility. If Jan doesn't get to it, we'll pick it up next week. Some of the issues with those files in mono\corefx had an incorrect tag of NET-CredScan-SpecialInput, which made us add exceptions to many of them, hence checked if these were going to be ported over. I'll make another pass on the mono\corefx issues under DevDiv\Mono early next week and update the tags.

[SamMonoRT]

@aik-jahoda - thank you for making the corresponding changes in mono/corefx via https://github.com/mono/corefx/pull/404/files

[danmoseley]

Let's try again.

[danmoseley]

@dotnet/ncl could someone please signoff on the networking/URI changes
@bartonjs could you ack the crypto changes

would like to merge this today if we can.

[danmoseley]

Still needs update to runtime-assets version to make tests pass

[aik-jahoda]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[danmoseley]

Just needs @bartonjs signoff, then we can merge but with special care to immediately cancel the official build.