Skip to content

Edit pass of notebooks #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 31, 2022
Merged

Edit pass of notebooks #37

merged 5 commits into from
May 31, 2022

Conversation

beccamc
Copy link
Contributor

@beccamc beccamc commented May 31, 2022

Spellcheck etc. of notebooks. Mainly fixed verb agreement issues

@luisquintanilla
Copy link
Contributor

@beccamc is this one ready for review? I mostly saw metadata changes in the diff.

@beccamc
Copy link
Contributor Author

beccamc commented May 31, 2022

Yeah this is ready! It's random markdown updates

@beccamc
Copy link
Contributor Author

beccamc commented May 31, 2022

@luisquintanilla Does it seem like the metadata changes are wrong? Do I need to re-run them to make sure everything looks good

@luisquintanilla
Copy link
Contributor

@luisquintanilla Does it seem like the metadata changes are wrong? Do I need to re-run them to make sure everything looks good

I don't think so. The diff experience could be better so it's hard to identify the changes to the markdown. Metadata changes I think happen automatically anytime you open notebooks. Let me give it another look.

luisquintanilla
luisquintanilla reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beccamc for doing this edit pass. Looks great. The E2E Classification Iris and E2E Forecasting with Regression notebooks still show the metadata changes.

luisquintanilla
luisquintanilla approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@beccamc beccamc merged commit 8b2bbad into dotnet:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisquintanilla luisquintanilla luisquintanilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beccamc @luisquintanilla