feat: plug in system implementation #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cified hander, or no handler are provided in config
Bumps [Microsoft.Extensions.Configuration.Binder](https://github.com/dotnet/runtime) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v7.0.0...v7.0.1) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.Binder dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
orgainized proxy-plugins project added namespace to abstractons and plugin projects converted console.write calls to use an ILogger added common response headers uitl to ProxyUtils
waldekmastykarz
requested changes
Jan 4, 2023
Co-authored-by: Waldek Mastykarz <waldek@mastykarz.nl>
waldekmastykarz
requested changes
Jan 5, 2023
msgraph-developer-proxy-plugins/Guidance/SelectGuidancePlugin.cs
Outdated
Show resolved
Hide resolved
msgraph-developer-proxy-plugins/Guidance/SelectGuidancePlugin.cs
Outdated
Show resolved
Hide resolved
gavinbarron
commented
Jan 9, 2023
waldekmastykarz
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors existing proxy features into plugins:
Adds a basic console logger to decouple console writing from plugin code allowing for richer formatting in future with minimal plugin changes
Adds an abstractions library to provide shared code and interface definitions for communication between the proxy and plugins
Adds common utilities to ProxyUtils class
Renames a few classes to better align to their usage