Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log WorkspaceFail events #1738

Merged
merged 1 commit into from Jun 8, 2017
Merged

Log WorkspaceFail events #1738

merged 1 commit into from Jun 8, 2017

Conversation

@dlech
Copy link
Contributor

@dlech dlech commented Jun 7, 2017

MSBuildWorkspace.OpenSolutionAsync() and MSBuildWorkspace.OpenProjectAsync() do not give any notification that loading a solution or project failed. However, there is a WorkspaceFailed event that we can use to be notified when there is a problem. This logs the diagnotic information from this event to help the user troubleshoot.

Related:

MSBuildWorkspace.OpenSolutionAsync() and MSBuildWorkspace.OpenProjectAsync() do not give any notification that loading a solution or project failed. However, there is a WorkspaceFailed event that we can use to be notified when there is a problem. This logs the diagnotic information from this event to help the user troubleshoot.

Related:
* dotnet/roslyn#19978 (comment)
* #1686
* #1708 (comment)
@dnfclas
Copy link

@dnfclas dnfclas commented Jun 7, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dlech
Copy link
Contributor Author

@dlech dlech commented Jun 7, 2017

Just realized I am making the assumption that the Logger is thread-safe. Hopefully that is the case.

@vicancy
vicancy approved these changes Jun 8, 2017
@vicancy vicancy merged commit 2e26c2e into dotnet:dev Jun 8, 2017
1 check failed
1 check failed
continuous-integration/teamcity Finished TeamCity Build Docfx CI :: dev : Exit code 1
Details
vicancy added a commit that referenced this pull request Jun 15, 2017
MSBuildWorkspace.OpenSolutionAsync() and MSBuildWorkspace.OpenProjectAsync() do not give any notification that loading a solution or project failed. However, there is a WorkspaceFailed event that we can use to be notified when there is a problem. This logs the diagnotic information from this event to help the user troubleshoot.

Related:
* dotnet/roslyn#19978 (comment)
* #1686
* #1708 (comment)
@dlech dlech deleted the dlech:log-workspace-failed branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.