New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log WorkspaceFail events #1738

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
3 participants
@dlech
Contributor

dlech commented Jun 7, 2017

MSBuildWorkspace.OpenSolutionAsync() and MSBuildWorkspace.OpenProjectAsync() do not give any notification that loading a solution or project failed. However, there is a WorkspaceFailed event that we can use to be notified when there is a problem. This logs the diagnotic information from this event to help the user troubleshoot.

Related:

Log WorkspaceFail events
MSBuildWorkspace.OpenSolutionAsync() and MSBuildWorkspace.OpenProjectAsync() do not give any notification that loading a solution or project failed. However, there is a WorkspaceFailed event that we can use to be notified when there is a problem. This logs the diagnotic information from this event to help the user troubleshoot.

Related:
* dotnet/roslyn#19978 (comment)
* #1686
* #1708 (comment)
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Jun 7, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Jun 7, 2017

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@dlech

This comment has been minimized.

Show comment
Hide comment
@dlech

dlech Jun 7, 2017

Contributor

Just realized I am making the assumption that the Logger is thread-safe. Hopefully that is the case.

Contributor

dlech commented Jun 7, 2017

Just realized I am making the assumption that the Logger is thread-safe. Hopefully that is the case.

@vicancy

vicancy approved these changes Jun 8, 2017

@vicancy vicancy merged commit 2e26c2e into dotnet:dev Jun 8, 2017

1 check failed

continuous-integration/teamcity Finished TeamCity Build Docfx CI :: dev : Exit code 1
Details

vicancy added a commit that referenced this pull request Jun 15, 2017

Log WorkspaceFail events (#1738)
MSBuildWorkspace.OpenSolutionAsync() and MSBuildWorkspace.OpenProjectAsync() do not give any notification that loading a solution or project failed. However, there is a WorkspaceFailed event that we can use to be notified when there is a problem. This logs the diagnotic information from this event to help the user troubleshoot.

Related:
* dotnet/roslyn#19978 (comment)
* #1686
* #1708 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment