Skip to content

Update .NET Standard to include disclaimer for .NET Framework #10504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2019

Conversation

terrajobst
Copy link
Contributor

@terrajobst terrajobst commented Feb 15, 2019

This is intended to be a better fix for #10448. We should remain truthful to the applicability rules of NuGet while also calling out that consuming .NET Standard 1.5+ from .NET Framework 4.6.1 really isn't a great experience that that the consumer should upgrade to .NET Framework 4.7.2.

Fixes #7305

/cc @SimonCropp

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left a comment for you to consider

Co-Authored-By: terrajobst <immo@landwerth.net>
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge when you're ready, @terrajobst.

@mairaw mairaw merged commit fd52a6b into master Feb 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the netstandard-disclaimer branch February 16, 2019 01:29
@mairaw
Copy link
Contributor

mairaw commented Feb 16, 2019

I merged for him 😄

@SimonCropp
Copy link
Contributor

Thanks peoples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify guidance .NET Standard 2.0 supported frameworks
4 participants