Skip to content

Conversation

gewarren
Copy link
Contributor

There was nothing in the VS glob/loc files that wasn't already included here, so this is just general clean-up including whitespace, sentence cap, in-article TOC, etc. Recommend diffing with ignore whitespace changes on.

Related to #3322.

@gewarren gewarren requested a review from rpetrusha February 15, 2019 23:43
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this content, @gewarren. I've tried to make it a bit less .NET Framework-centric and more relevant to .NET Core -- I hope that you don't mind the large number of suggested changes, almost all of which are unrelated to your PR. The content remains much too .NET Framework-centric, but at least this was a start in the right direction.
Once you've made the changes, you can merge.

Ron Petrusha and others added 24 commits February 19, 2019 16:40
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…lly.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…pps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…lly.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…lly.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…lly.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…lly.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…lly.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
Ron Petrusha and others added 17 commits February 19, 2019 16:49
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…veloping-world-ready-apps.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
…tring-operations.md

Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
Co-Authored-By: gewarren <gewarren@microsoft.com>
@mairaw
Copy link
Contributor

mairaw commented Feb 20, 2019

Tip: You can batch all the suggestions into a single commit via the Files tab

@gewarren
Copy link
Contributor Author

@mairaw Ahh, thanks. That would have been a much better way to go.

@gewarren gewarren merged commit 6e492d1 into dotnet:master Feb 20, 2019
@gewarren gewarren deleted the glob-loc branch February 20, 2019 03:21
@gewarren
Copy link
Contributor Author

@rpetrusha Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants