Skip to content

Conversation

v-makoud
Copy link
Contributor

Hello @yishengjin1413,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description of the source issue:
The link is not being rendered as clickable on LOC pages, while on EN it is. The link is not working though. Should the link be clickable? If link should be clickable then it should be written like this, so it works on LOC pages too.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.

Summary

Describe your changes here.

Fixes #Issue_Number (if available)

Hello @yishengjin1413,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description of the source issue:
The link is not being rendered as clickable on LOC pages, while on EN it is. The link is not working though. Should the link be clickable? If link should be clickable then it should be written like this, so it works on LOC pages too.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
@v-makoud v-makoud changed the title C67698: Shiuld the link be clickable? C67698: Should the link be clickable? Feb 21, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since link doesn't work, suggesting a different change instead

@mairaw mairaw added the loc Indicates issues that are about localized content [org][type][category] label Feb 21, 2019
@mairaw mairaw added this to the February 2019 milestone Feb 21, 2019
Co-Authored-By: v-makoud <42440351+v-makoud@users.noreply.github.com>
@v-makoud
Copy link
Contributor Author

thanks @mairaw I committed the change

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-makoud! 👍

@mairaw mairaw merged commit 70d3c81 into dotnet:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loc Indicates issues that are about localized content [org][type][category]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants