Skip to content

Conversation

rpetrusha
Copy link
Contributor

Noted Like operator is not supported in .NET Core

//cc @KathleenDollard

@rpetrusha rpetrusha added this to the February 2019 milestone Feb 22, 2019
@rpetrusha rpetrusha self-assigned this Feb 22, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a suggestion for you to consider. Plus should we update the date?

@KathleenDollard
Copy link
Contributor

Looks great.

It brings to mind that with VB.NET 16 timeframe, we'll be adding back functionality like this that .NET Core is currently missing. Is there an obvious technique for how we mark features that are missing on .NET Core prior to 16.0?

Co-Authored-By: rpetrusha <ronpet@microsoft.com>
@rpetrusha
Copy link
Contributor Author

I think we could add a custom label that at least indicates we should review it. What do you think, @mairaw? Possibly just the "updateeachrelease" metadata value, which we can remove once it is supported in .NET Core.

@mairaw
Copy link
Contributor

mairaw commented Feb 22, 2019

Yeah, that could work. Or we could add a Dev16 project. I think there's more we'll have to worry about for that release.

@rpetrusha
Copy link
Contributor Author

I'll create a Dev16 project.

@rpetrusha rpetrusha merged commit 5ed443d into dotnet:master Feb 22, 2019
@rpetrusha rpetrusha deleted the like-operator branch February 22, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants