Skip to content

fix issue 1255: Move snippets to the snippets location #2 #10817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2019
Merged

fix issue 1255: Move snippets to the snippets location #2 #10817

merged 3 commits into from
Feb 28, 2019

Conversation

yishengjin1413
Copy link
Contributor

@yishengjin1413 yishengjin1413 commented Feb 28, 2019

Related to #10774 .

  1. Please help to check this PR first . Some codesnippets are changed in dotnet/docs repo and the PR is used to move the changes to samples repo. Before that pr merged, this pr build may get some warnings or the page may looks different from before.
  2. There are four topics left which I didn't fix. Since I can't find the codesnippet from samples repo. So please manually fix them.
    1. docs\csharp\programming-guide\strings\index.md
    2. docs\csharp\programming-guide\arrays\single-dimensional-arrays.md
    3. docs\visual-basic\reference\command-line-compiler\imports.md
    4. docs\visual-basic\programming-guide\language-features\events\index.md
  3. For deleting the the snippets in this repo, I think you can remove all the snippet folders after this four topics fixed. Or I can send a separate PR to delete no-used snippets later after these two PR merged.

Contributes #1255

@BillWagner
Copy link
Member

closing and reopening to start a new build to pick up new samples PRs

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yishengjin1413! I've checked a few before and after and they all look great. I'll check the topics you listed and create a PR to remove all codesnippet folders.

Thank you so much for your help with this! ❤️

@mairaw mairaw merged commit d5f4a01 into dotnet:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants