-
Notifications
You must be signed in to change notification settings - Fork 6k
update lang version docs #10825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BillWagner
merged 7 commits into
dotnet:master
from
BillWagner:update-lang-version-options
Mar 1, 2019
Merged
update lang version docs #10825
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7501727
update lang version docs
BillWagner efde703
Update docs/csharp/language-reference/compiler-options/langversion-co…
pkulikov f2f85b2
add trailing whitespace for formatting on footnotes.
BillWagner 71ccb45
Merge branch 'update-lang-version-options' of https://github.com/Bill…
BillWagner aa4740e
lower case for consistency
BillWagner 9892552
Apply suggestions from code review
mairaw 63d81e8
fix links and branding.
BillWagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the blog post, option names start with capital:
Latest
andLatestMajor
. Throughout the changes in this PR both of them start with the small letter, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's by design. The element values are case-insensitive. Do you think that adds or detracts from understanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As they are case-insensitive, it's more nit-picking then. Should then
Preview
be changed topreview
for consistency?