-
Notifications
You must be signed in to change notification settings - Fork 6k
C76762: Removing all "\" at the end of lines and adding two spaces in… #11541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…stead Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
#sign-off |
I'd like to understand why we're doing this @v-makoud. Is this breaking for Loc? /cc @JasonCard |
Ah sorry, missed the reply there and couldn't find that PR this morning. Yes, his solution to code fence is a good workaround. Eventually, I'd like to fix all those sections to add the links and formatting as we used to have in MSDN back in the day like we did here: For that, I guess we'd have to use explicit <br /> tags. This is related to this discussion: MicrosoftDocs/feedback#1264 I'll have to review all the uses of that \ at the end of a line because we have other places we've been using that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the ``` syntax here then @v-makoud? It would be preferable vs. adding spaces.
If this could match what we had on MSDN before (indentation and node names, except the last one shouldn't say element), even better:
@mairaw yes we can use this. |
@nemrism Those affected files under subfolder https://github.com/dotnet/docs/blob/live/docs/framework/configure-apps/ are machine translated and should be localized by Monday morning. Then you can check how it's displayed in live page. |
Thanks @JasonCard I already see some issues with the automated translation, here: Some elements get translated which is something incorrect as configuration file schema is not meant to be translated. Is there a way to tell the automatic translation to avoid this? |
@nemrism Thank you for checking. |
Let me test something else with the no-loc feature @nemrism. @JasonCard but there was also a question about being able to use \ as the new line at the end of sentences. We got some PRs from the loc team telling us that this would cause issues for Loc. Related discussion: MicrosoftDocs/feedback#1264 |
Actually @JasonCard, there is already another paragraph using code block to present the syntax of the configuration files XML. The goal of the lines at the beginning of the article, the ones you can see in the screenshot, is to respect the hierarchy while linking to the pages of the parent elements. So we should find a solution to have them presented like this, with links on almost each lines. And the best solution would also allow us to tell the automatic translation to leave those links not translated. Thanks @mairaw, I'll wait for your feedback. |
@mairaw @nemrism I see, yes, the no-loc feature can also be used to block text from localization. |
Thanks, I'll check the documentation of the no-loc if I can find some. Or will wait for @mairaw's sample/test results. |
…stead
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)