Skip to content

Fix up confusing comments #11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2019
Merged

Fix up confusing comments #11689

merged 1 commit into from
Apr 5, 2019

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Apr 5, 2019

Fixes #11686

rpetrusha
rpetrusha approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge when you're ready, @cartermp.

@rpetrusha rpetrusha added this to the April 2019 milestone Apr 5, 2019
@cartermp cartermp merged commit 2aba9ac into master Apr 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the cartermp-patch-1 branch April 5, 2019 21:19
@mairaw mairaw removed this from the April 2019 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermp @rpetrusha @mairaw