Skip to content

Replace .NET Framework tokens #12292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

Replace .NET Framework tokens #12292

merged 1 commit into from
May 13, 2019

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented May 10, 2019

No description provided.

@nxtn nxtn requested a review from BillWagner as a code owner May 10, 2019 15:59
BillWagner
BillWagner approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @NextTurn

I've reviewed the changes, and I'll :shipit: now.

Thanks again.

@BillWagner BillWagner merged commit b666241 into dotnet:master May 13, 2019
@nxtn nxtn deleted the net-2 branch May 13, 2019 14:55
@nxtn
Copy link
Contributor Author

nxtn commented May 13, 2019

@BillWagner Does it mean that most of the [!INCLUDE...] tokens should be replaced by the target content?

@BillWagner
Copy link
Member

Ping @rpetrusha for details on which includes are being removed.

I think we want to remove most of them, but Ron would have the best answer.

@nxtn nxtn mentioned this pull request May 15, 2019
Merged
@nxtn nxtn changed the title Replace .NET Framework includes Replace .NET Framework tokens May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nxtn @BillWagner