Skip to content

Spark Dotnet: fix API links #12300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2019
Merged

Spark Dotnet: fix API links #12300

merged 3 commits into from
May 13, 2019

Conversation

mamccrea
Copy link
Contributor

Summary

Changing API links.

@mamccrea mamccrea requested a review from JasonWHowell May 10, 2019 23:23
@mairaw
Copy link
Contributor

mairaw commented May 11, 2019

You only have that one namespace @mamccrea? It seems that your repo wasn't indexed given that https://docs.microsoft.com/en-us/dotnet/api/?view=spark-dotnet is empty.

@JasonWHowell
Copy link
Contributor

@mamccrea looks like the index includes .Net for Spark now.
image

@JasonWHowell
Copy link
Contributor

JasonWHowell commented May 13, 2019

@mamccrea Do you want the new link going to the Microsoft.Spark namespace directly, or to the index of all the namespaces in the listing (original link)?

Old: https://docs.microsoft.com/dotnet/api/?view=spark-dotnet
New: https://docs.microsoft.com/dotnet/api/Microsoft.Spark

@mamccrea
Copy link
Contributor Author

@JasonWHowell - I see the index is working now, but for some reason I'm getting a 404 when I try to get there from the docs index page (https://docs.microsoft.com/en-us/dotnet/spark/). I'll investigate that.

@mairaw
Copy link
Contributor

mairaw commented May 13, 2019

That one is missing the dotnet in the path.

@mairaw
Copy link
Contributor

mairaw commented May 13, 2019

Left a suggestion for you on how to fix that one, but it's probably better to leave the other ones going to the API Browser page and not one specific namespace.

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Copy link
Contributor

@JasonWHowell JasonWHowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links work from the TOC and the landing page as expected. Looks good to me! #sign-off

@JasonWHowell JasonWHowell merged commit 297df73 into dotnet:master May 13, 2019
@mairaw mairaw added this to the May 2019 milestone May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants