-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostic CLI tools #13981
Diagnostic CLI tools #13981
Conversation
This is a very early draft. |
85014ec
to
4f33a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sdmaclea ! I added a few small feedback items but this is a major improvement over where we have been.
@mairaw @rpetrusha Please review. |
@mairaw @rpetrusha @Thraka Please review. |
@mairaw @rpetrusha @Thraka ping |
Apologies on missing the multiple pings for reviews @sdmaclea! I'll review this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sdmaclea. Left some comments for you to consider.
5c32f79
to
ae717dc
Compare
ae717dc
to
c760471
Compare
@mairaw I believe your feedback has been addressed. Please have another look. |
@mairaw ping |
I'm wondering if this content should live under https://docs.microsoft.com/en-us/dotnet/core/additional-tools/. Otherwise, we're creating a third-place on the TOC that talks about tools. We could break down that node into WCF and Diagnostics. Thoughts? |
We are trying to create a single landing page for diagnostic tools. We would like it to be easily discoverable. Something like https://golang.org/doc/diagnostics.html. If we think about diagnostic tool users, there are two distinct questions:
I think https://docs.microsoft.com/en-us/dotnet/core/additional-tools/ better suits the Survey case. I think https://docs.microsoft.com/en-us/dotnet/core/additional-tools/diagnostics is better for the Reference case. As a developer I tend to bias toward the Reference case, so that tends to be my innate preference. I would probably include in both overviews to make it more discoverable. #14110 will add more tutorial info related to some of these tools. FWIW the existing https://docs.microsoft.com/en-us/dotnet/core/additional-tools/ overwhelmed me. It is loaded with heavy acronym usage, and very little conceptual background. I felt like I got whip lash trying to read it. It felt out of place. It needed to be in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Add documentation for adding and using the diagnostic command line tools.