Skip to content

US 1583733 Add missing language IDs - 12 #14209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2019
Merged

US 1583733 Add missing language IDs - 12 #14209

merged 6 commits into from
Oct 28, 2019

Conversation

v-thpra
Copy link
Contributor

@v-thpra v-thpra commented Sep 4, 2019 •
edited by mairaw
Loading

US 1583733 - Fix CATS P1 issues by adding missing language IDs to code blocks.

  • Used "output" for program output examples.
  • Used "csharp" for ADO.NET connection string examples.
  • Used "text" for examples of the relation between DataSet components.

Contributes to #2192

@v-thpra v-thpra requested a review from stevestein as a code owner September 4, 2019 21:59
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Sep 4, 2019
@mairaw mairaw added this to the September 2019 milestone Sep 4, 2019
@v-thpra v-thpra requested a review from HongGit as a code owner September 5, 2019 17:46
@v-thpra
Copy link
Contributor Author

v-thpra commented Sep 24, 2019

@mairaw Conflicts and changes have been resolved. This should be ready to merge. Thanks!

BillWagner
BillWagner approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @v-thpra

I'll :shipit: now.

/

@BillWagner BillWagner merged commit 65b297d into dotnet:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@BillWagner BillWagner BillWagner approved these changes

@stevestein stevestein Awaiting requested review from stevestein

@HongGit HongGit Awaiting requested review from HongGit

Assignees

@v-thpra v-thpra

Labels
data-access/subsvc dotnet-framework/svc vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.
6 participants
@v-thpra @BillWagner @Youssef1313 @Thraka @dotnet-bot @mairaw