Skip to content

US 1583733 Add missing language IDs - 31 #14375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2019
Merged

US 1583733 Add missing language IDs - 31 #14375

merged 2 commits into from
Sep 11, 2019

Conversation

v-thpra
Copy link
Contributor

@v-thpra v-thpra commented Sep 11, 2019

US 1583733 - Fix CATS P1 issues by adding missing language IDs to code blocks.

  • Used "console" for command-line tool examples (Svcutil.exe).
  • Used "bat" for .bat file examples.

Contributes to #2192

@v-thpra v-thpra requested a review from HongGit as a code owner September 11, 2019 19:34
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Sep 11, 2019
@mairaw mairaw added this to the September 2019 milestone Sep 11, 2019
mairaw
mairaw approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @v-thpra! Thanks.

@mairaw mairaw merged commit 0b2973c into dotnet:master Sep 11, 2019
@v-thpra v-thpra deleted the US1583733-batch-31 branch September 11, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

@HongGit HongGit Awaiting requested review from HongGit

Assignees
No one assigned
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@v-thpra @mairaw