Added additional breaking changes #14386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thraka
reviewed
Sep 16, 2019
Thraka
suggested changes
Sep 16, 2019
includes/core-changes/cryptography/better-argument-validation-in-pkcs8privatekeyinfo-ctor.md
Outdated
Show resolved
Hide resolved
includes/core-changes/cryptography/envelopedcms-defaults-to-aes256.md
Outdated
Show resolved
Hide resolved
includes/core-changes/cryptography/envelopedcms-defaults-to-aes256.md
Outdated
Show resolved
Hide resolved
|
|
||
| Starting with .NET Core 3.0 Preview 8 (via version 4.6.0 of the [System.Security.Cryptography.Pkcs](https://www.nuget.org/packages/System.Security.Cryptography.Pkcs/) NuGet package), the default algorithm has been changed to AES-256 for algorithm modernization and to improve the security of default options. If a message recipient certificate has a (non-EC) Diffie-Hellman public key, the encryption operation may fail with a <xref:System.Security.Cryptography.CryptographicException> due to limitations in the underlying platform. | ||
|
|
||
| In the following sample code, the data is encrypted with TripleDES if running on .NET Core 3.0 Preview 7 or earlier. If running on .NET Core 3.0 Preview 8 or later, it is encrypted with AES-257. |
There was a problem hiding this comment.
Suggested change
| In the following sample code, the data is encrypted with TripleDES if running on .NET Core 3.0 Preview 7 or earlier. If running on .NET Core 3.0 Preview 8 or later, it is encrypted with AES-257. | |
| In the following sample code, the data is encrypted with `TripleDES` if running on .NET Core 3.0 Preview 7 or earlier. If running on .NET Core 3.0 Preview 8 or later, it is encrypted with AES-257. |
|
|
||
| #### Recommended action | ||
|
|
||
| If you are negatively impacted by the change, you can restore TripleDES encryption by explicitly specifying the encryption algorithm identifier in an <xref:System.Security.Cryptography.Pkcs.EnvelopedCms> constructor that includes a parameter of type <xref:System.Security.Cryptography.Pkcs.AlgorithmIdentifier>, such as: |
There was a problem hiding this comment.
Suggested change
| If you are negatively impacted by the change, you can restore TripleDES encryption by explicitly specifying the encryption algorithm identifier in an <xref:System.Security.Cryptography.Pkcs.EnvelopedCms> constructor that includes a parameter of type <xref:System.Security.Cryptography.Pkcs.AlgorithmIdentifier>, such as: | |
| If you are negatively impacted by the change, you can restore `TripleDES` encryption by explicitly specifying the encryption algorithm identifier in an <xref:System.Security.Cryptography.Pkcs.EnvelopedCms> constructor that includes a parameter of type <xref:System.Security.Cryptography.Pkcs.AlgorithmIdentifier>, such as: |
includes/core-changes/cryptography/minimum-rsaopenssl-key-size-change.md
Outdated
Show resolved
Hide resolved
…-change.md Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>
rpetrusha
requested review from
BillWagner,
HongGit,
KathleenDollard,
mamccrea,
natke,
nishanil and
stevestein
as code owners
rpetrusha
force-pushed
the
compat-3-0-2
branch
from
6ad716c to
35cb213
Compare
Thraka
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional breaking changes
Link to internal review site
//cc @PriyaPurkayastha