Microservices guide general update to 3.1 #16202

mvelosop · 2019-12-11T15:22:07Z

Summary

Update microservices guide to .NET Core 3.1 and related versions

Tracked in https://github.com/dotnet-architecture/Issues/issues/52

mairaw · 2019-12-11T19:31:47Z

@mvelosop did you create that label or was an existing one? Adding WIP to the PR title will block it from merging.

mvelosop · 2019-12-12T22:34:00Z

Hi @mairaw, that label already existed. I began looking for the WIP label, that I remember having seen sometime, but doesn't exist anymore, and then I saw this one.

The other PR using this label is #13565.

But if WIP is enough I have no problem, of course, for it to be removed. 😉

mairaw · 2019-12-12T22:53:32Z

No worries. We cleaned up a lot of labels from our repo recently so I was just curious.

…docs into microservices-3.1/update

nishanil

@mvelosop Looks good. I have requested a few changes.
I think, for API Gateway with Envoy implementation and Resiliency with Service Mesh, we should link the appropriate wiki articles in the Important section. In the future, we should be writing it in the book itself.

docs/architecture/microservices/index.md

...architecture/microservices/net-core-net-framework-containers/net-core-container-scenarios.md

...tecture/microservices/net-core-net-framework-containers/net-framework-container-scenarios.md

...rvices/architect-microservice-container-applications/containerize-monolithic-applications.md

docs/architecture/microservices/microservice-ddd-cqrs-patterns/implement-value-objects.md

docs/architecture/microservices/microservice-ddd-cqrs-patterns/microservice-domain-model.md

docs/architecture/microservices/implement-resilient-applications/index.md

nishanil · 2020-01-14T10:12:52Z

@mairaw I have reviewed the content itself. If you see anything alarming with respect to docs' guidelines, please let us know :)

Co-Authored-By: Nish Anil <nish@microsoft.com>

mvelosop

Not sure why I had to make this comment 🙄

...architecture/microservices/net-core-net-framework-containers/net-core-container-scenarios.md

Missed review comment Co-Authored-By: Nish Anil <nish@microsoft.com>

mvelosop · 2020-02-06T18:13:16Z

@mairaw, I think we're ready now!

mairaw · 2020-02-08T00:25:16Z

There are still some warnings on the build report @mvelosop. Can you check?

mvelosop · 2020-02-08T12:57:40Z

@mairaw, where can I see the build report?

Everything looks fine here:

nishanil · 2020-02-11T04:18:21Z

@mvelosop Click on the Details on OpenPublishing.Build — Validation status: warnings. We have to fix the warnings too.

mairaw

I'll try to continue to add more comments later today

docs/architecture/microservices/implement-resilient-applications/monitor-app-health.md

mairaw

I finished going through all changes now. A few more suggestions...

docs/architecture/microservices/microservice-ddd-cqrs-patterns/implement-value-objects.md

docs/architecture/microservices/secure-net-microservices-web-applications/index.md

docs/architecture/microservices/microservice-ddd-cqrs-patterns/implement-value-objects.md

...ce-ddd-cqrs-patterns/infrastructure-persistence-layer-implemenation-entity-framework-core.md

docs/architecture/microservices/net-core-net-framework-containers/official-net-docker-images.md

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

…ns/monitor-app-health.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

mvelosop · 2020-02-17T17:02:50Z

@mairaw, just realized that there were comments in the "Conversation" tab that I missed while in the "Files changed" tab, So I reviewed the whole conversation of this PR, and added the changes in the previous commit.

Is it OK with you if we merge this one now, so I can generate the new e-book release? 😊 please 🥺

nishanil

Looks good. Merging changes now. We will address any other issues in a new PR.

* fix last msdn blogs urls (#17089) * fix last msdn blogs urls * Remove locale * Remove period * Microservices guide general update to 3.1 (#16202) * Update authentication * Update Visual Studio 2017 references and images * Update references and some code snippets to 3.1 * Update references + code snippets to 3.1 * Update IHostedServices Section * Update value objects section * Apply suggestions from code review Co-Authored-By: Nish Anil <nish@microsoft.com> * Apply suggestions from code review Co-Authored-By: Nish Anil <nish@microsoft.com> * Apply further review comments * Fix Markdownlinter errors * Apply suggestions from code review Missed review comment Co-Authored-By: Nish Anil <nish@microsoft.com> * Fix image name * Update edit dates * Remove remnant temporary file * Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md * Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md * Replaced Important with Note * Update implement-api-gateways-with-ocelot.md * Fix blank lines * Update position * Apply suggestions from code review (to be continued...) Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply suggestions from code review Ready with suggestions, manual changes are coming next. Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply manual changes from reviews. * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add more review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Remove locale from link * Update docs/architecture/microservices/implement-resilient-applications/monitor-app-health.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add review comment from local repo. Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Maira Wenzel <mairaw@microsoft.com> * Update Azure table offerings for application Architecture (#17011) * Update table - Update recommendations - Convert it to markdown for accessibility * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply review comments. Co-authored-by: Maira Wenzel <mairaw@microsoft.com> * Document warnaserror:nullable option (#17094) * Modulo operator -> remainder operator (#17102) * update some CLI ref commands for 3.1 (#17101) * update CLI ref commands for 3.1 * fix * Add link to tutorial of using pattern matching (#17108) * Remove the note about the struct breaking change from the conceptual docs (#17114) * Fix the note about the struct breaking change * Removed the note Co-authored-by: Maira Wenzel <mairaw@microsoft.com> Co-authored-by: Miguel Veloso <mvelosop@gmail.com> Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com> Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com>

* #15390 Remove links to outdated tutorials on string interpolation (#15401) * Update live with current master (#16095) * updating links from fwlink to real link if exists (#15945) * updating links from fwlink to real link if exists * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * undoing linking change * Update docs/framework/whats-new/obsolete-types.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * updating aspnet links * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content (#14590) * [DocsArchive-1.0.19259.5](2019-09-22-20-26-07)Auto archive content * additional changes * Updates for the new dotnet/runtime repo (#15983) * Update system-text-json-overview.md * Update system-text-json-overview.md * Update system-text-json-overview.md * Update about.md * Update instructions for RHEL (#16050) * Update instructions for RHEL * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Update date * Fixes #11069 (#16058) * Fix typo in timespan format (#16071) * Replace Windows 7/8 tokens (#16074) * Replace Windows 7 tokens * Remove win7-md.md * Replace Windows 8 tokens * Remove win8-md.md * Replace Windows 8.1 tokens * Remove win81-md.md * add later versions (#16076) * add later versions * Apply suggestions from docs review Co-Authored-By: Genevieve Warren <gewarren@microsoft.com> * remove version from link text (#16077) * Spark: spark streaming article (#15842) * spark streaming article * make spark streaming a tutorial * Update docs/spark/tutorials/streaming.md Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * update link * Update docs/spark/tutorials/streaming.md Co-Authored-By: Bill Wagner <wiwagn@microsoft.com> * update xrefs * fix xref * Update unit-testing-with-dotnet-test.md (#15954) * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Apply suggestions from code review Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com> * Update unit-testing-with-dotnet-test.md * Update unit-testing-with-dotnet-test.md * Update docs/core/testing/unit-testing-with-dotnet-test.md Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com> * Run-time config knobs (#16019) * add settings to toc * add config files for various settings * add working with calendars changes * updating links from fwlink to real link if exists (#16065) * updating links from fwlink to real link if exists - contributes to #3391 * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * undoing samples fwlink * Update docs/framework/windows-workflow-foundation/how-to-host-multiple-versions-of-a-workflow-side-by-side.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * add a later version (#16080) * add a later version * more updates * Update docs/framework/debug-trace-profile/pinvokestackimbalance-mda.md Co-Authored-By: Genevieve Warren <gewarren@microsoft.com> * fix backtick escaping (#16056) * separate OS info (#16063) * Typo, add missing "s" (#16093) * update live with master (#17118) * fix last msdn blogs urls (#17089) * fix last msdn blogs urls * Remove locale * Remove period * Microservices guide general update to 3.1 (#16202) * Update authentication * Update Visual Studio 2017 references and images * Update references and some code snippets to 3.1 * Update references + code snippets to 3.1 * Update IHostedServices Section * Update value objects section * Apply suggestions from code review Co-Authored-By: Nish Anil <nish@microsoft.com> * Apply suggestions from code review Co-Authored-By: Nish Anil <nish@microsoft.com> * Apply further review comments * Fix Markdownlinter errors * Apply suggestions from code review Missed review comment Co-Authored-By: Nish Anil <nish@microsoft.com> * Fix image name * Update edit dates * Remove remnant temporary file * Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md * Update docs/architecture/microservices/multi-container-microservice-net-applications/implement-api-gateways-with-ocelot.md * Replaced Important with Note * Update implement-api-gateways-with-ocelot.md * Fix blank lines * Update position * Apply suggestions from code review (to be continued...) Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply suggestions from code review Ready with suggestions, manual changes are coming next. Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply manual changes from reviews. * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add more review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Remove locale from link * Update docs/architecture/microservices/implement-resilient-applications/monitor-app-health.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add review comments * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Add review comment from local repo. Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Maira Wenzel <mairaw@microsoft.com> * Update Azure table offerings for application Architecture (#17011) * Update table - Update recommendations - Convert it to markdown for accessibility * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Apply review comments. Co-authored-by: Maira Wenzel <mairaw@microsoft.com> * Document warnaserror:nullable option (#17094) * Modulo operator -> remainder operator (#17102) * update some CLI ref commands for 3.1 (#17101) * update CLI ref commands for 3.1 * fix * Add link to tutorial of using pattern matching (#17108) * Remove the note about the struct breaking change from the conceptual docs (#17114) * Fix the note about the struct breaking change * Removed the note Co-authored-by: Maira Wenzel <mairaw@microsoft.com> Co-authored-by: Miguel Veloso <mvelosop@gmail.com> Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com> Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com> * Add f1_keywords to keyword-reference (#17624) These keywords are listed in archived F# keywords topic (https://docs-archive.visualstudio.com/docs-archive-project/_git/VS2013-docs-archive-pr?path=%2Fvs-2013%2Fdd233249(v%3Dvs.120).md&amp%3Bversion=GBlive&amp%3B_a=contents). Docs.F1 needs these keywords added in the fresh content to return a fresh result for those F1 keywords. * Revert "Install for Ubuntu 20.04 (#17869)" (#18089) (#18092) This reverts commit 7eb84cf. * Fix default checksum algorithm Fixes #18925 Co-authored-by: Maira Wenzel <mairaw@microsoft.com> Co-authored-by: Ron Petrusha <ronpet@microsoft.com> Co-authored-by: Pablo Marcano <pablo1012@outlook.com> Co-authored-by: Andy De George <2672110+Thraka@users.noreply.github.com> Co-authored-by: Genevieve Warren <gewarren@microsoft.com> Co-authored-by: Tom Dykstra <tdykstra@microsoft.com> Co-authored-by: Miguel Veloso <mvelosop@gmail.com> Co-authored-by: Nish Anil <nish@microsoft.com> Co-authored-by: Julien Couvreur <jcouv@users.noreply.github.com> Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com> Co-authored-by: Roman Marusyk <Marusyk@users.noreply.github.com> Co-authored-by: Nat Kershaw (MSFT) <nakersha@microsoft.com> Co-authored-by: CXWTool Service Account <cxwtool@microsoft.com> Co-authored-by: junshi356 <40595015+junshi356@users.noreply.github.com> Co-authored-by: David Pine <david.pine@microsoft.com>

Update authentication

785b888

mvelosop requested a review from nishanil as a code owner December 11, 2019 15:22

dotnet-bot added this to the December 2019 milestone Dec 11, 2019

dotnet-bot added 📖 guide - .NET Microservices labels Dec 11, 2019

mvelosop added the DO NOT MERGE label Dec 11, 2019

mairaw changed the title ~~Microservices guide general update to 3.1~~ WIP Microservices guide general update to 3.1 Dec 11, 2019

Update Visual Studio 2017 references and images

f0f702f

mvelosop added 6 commits December 13, 2019 08:13

Update references and some code snippets to 3.1

40e93ff

Update references + code snippets to 3.1

d9cd82e

Merge branch 'master' into microservices-3.1/update

03b08cb

Update IHostedServices Section

272dffd

Merge branch 'microservices-3.1/update' of https://github.com/dotnet/…

62e0b32

…docs into microservices-3.1/update

Update value objects section

7f9ee00

This was referenced Jan 8, 2020

Update Docker Images in the table to latest (3.1) #16500

Closed

Update Docker Images in the table to latest (3.1) #16503

Closed

mairaw assigned mvelosop Jan 9, 2020

nishanil requested changes Jan 14, 2020

View reviewed changes

nishanil mentioned this pull request Jan 22, 2020

fix/remove broken links #16743

Merged

mvelosop and others added 2 commits January 22, 2020 16:18

Apply suggestions from code review

f308b99

Co-Authored-By: Nish Anil <nish@microsoft.com>

Apply suggestions from code review

9bb06e3

Co-Authored-By: Nish Anil <nish@microsoft.com>

mvelosop commented Jan 22, 2020

View reviewed changes

...architecture/microservices/net-core-net-framework-containers/net-core-container-scenarios.md Outdated Show resolved Hide resolved

Miguel Veloso and others added 4 commits January 22, 2020 16:28

Apply further review comments

bc1a4c7

Fix Markdownlinter errors

662d999

Apply suggestions from code review

7dbee92

Missed review comment Co-Authored-By: Nish Anil <nish@microsoft.com>

Merge branch 'master' into microservices-3.1/update

09c6dd8

Apply manual changes from reviews.

26c3018

mairaw reviewed Feb 12, 2020

View reviewed changes

mairaw removed the changes-addressed label Feb 12, 2020

mairaw reviewed Feb 12, 2020

View reviewed changes

docs/architecture/microservices/net-core-net-framework-containers/official-net-docker-images.md Outdated Show resolved Hide resolved

mvelosop and others added 7 commits February 13, 2020 19:00

Apply suggestions from code review

1010808

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

Add more review comments

c892efe

Apply suggestions from code review

202cd3b

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

Remove locale from link

e501e61

Update docs/architecture/microservices/implement-resilient-applicatio…

a76e276

…ns/monitor-app-health.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

Add review comments

9fde1f3

Apply suggestions from code review

37ba7bd

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

mvelosop mentioned this pull request Feb 17, 2020

Fix typo in file name #17111

Closed

Add review comment from local repo.

09918f7

mvelosop requested a review from mairaw February 17, 2020 17:03

nishanil approved these changes Feb 18, 2020

View reviewed changes

nishanil merged commit 5ce8b2d into master Feb 18, 2020

nishanil deleted the microservices-3.1/update branch February 18, 2020 04:40

BillWagner added dotnet-architecture/svc microservices/subsvc and removed 📚 Area - .NET Architecture Guide labels Feb 9, 2021

Microservices guide general update to 3.1 #16202

Microservices guide general update to 3.1 #16202

Uh oh!

Conversation

mvelosop commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

mairaw commented Dec 11, 2019

Uh oh!

mvelosop commented Dec 12, 2019

Uh oh!

mairaw commented Dec 12, 2019

Uh oh!

nishanil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nishanil commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mvelosop left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mvelosop commented Feb 6, 2020

Uh oh!

mairaw commented Feb 8, 2020

Uh oh!

mvelosop commented Feb 8, 2020

Uh oh!

nishanil commented Feb 11, 2020

Uh oh!

mairaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mairaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mvelosop commented Feb 17, 2020

Uh oh!

nishanil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mvelosop commented Dec 11, 2019 •

edited

Loading

nishanil commented Jan 14, 2020 •

edited

Loading