Skip to content

Style guide-ish improvements #16419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 21, 2020
Merged

Style guide-ish improvements #16419

merged 8 commits into from
Jan 21, 2020

Conversation

gewarren
Copy link
Contributor

Also add .NET Standard to the title.
Localizability improvements.

Co-Authored-By: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
@gewarren gewarren requested a review from mairaw January 7, 2020 01:50
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gewarren. Left a few comments for you to consider.

gewarren and others added 3 commits January 14, 2020 15:02
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@gewarren
Copy link
Contributor Author

@mairaw I've addressed all of your feedback. Could you take another look?

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a minor comment for you to consider.

@gewarren
Copy link
Contributor Author

Thanks for the review Maira!

@gewarren gewarren merged commit 1e02254 into master Jan 21, 2020
@gewarren gewarren deleted the gewarren-patch-3 branch January 21, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants