Skip to content

updating links from fwlink to real link if exists #16719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2020
Merged

updating links from fwlink to real link if exists #16719

merged 3 commits into from
Jan 17, 2020

Conversation

eddynaka
Copy link
Contributor

updating links from fwlink to real link if exists - contributes to #3391

@eddynaka eddynaka requested a review from HongGit as a code owner January 16, 2020 21:58
@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 16, 2020
@eddynaka eddynaka requested a review from mairaw January 16, 2020 21:58
@mairaw mairaw removed the request for review from HongGit January 16, 2020 22:00
@mairaw mairaw assigned eddynaka and dreddy-work and unassigned dreddy-work Jan 16, 2020
mairaw
mairaw requested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eddynaka. Left a few comments for you before we can merge this.

@eddynaka @mairaw
Apply suggestions from code review
cb9d9b7 
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
mairaw
mairaw reviewed Jan 17, 2020
View reviewed changes
@eddynaka @mairaw
Apply suggestions from code review
0bc0225 
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
mairaw
mairaw approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mairaw mairaw merged commit 64cd068 into dotnet:master Jan 17, 2020
@eddynaka eddynaka deleted the updating-framework-to-https-p14 branch February 11, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@eddynaka eddynaka

Labels
dotnet-framework/svc wcf/subsvc
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@eddynaka @mairaw @BillWagner @dotnet-bot @dreddy-work