Skip to content

Add emoji text where needed #16722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2020
Merged

Add emoji text where needed #16722

merged 2 commits into from
Jan 17, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 17, 2020 •
edited
Loading

Fixes #13000

Related to #16721

@dotnet-bot dotnet-bot added this to the January 2020 milestone Jan 17, 2020
@gewarren gewarren requested a review from mairaw January 17, 2020 00:33
mairaw
mairaw approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren
Copy link
Contributor Author

Thanks for reviewing, Maira!

@gewarren gewarren merged commit 21b096f into dotnet:master Jan 17, 2020
@gewarren gewarren deleted the emoji-text branch January 17, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2020
Development

Successfully merging this pull request may close these issues.

Using the check and cross marks to convey meaning is an accessibility issue
4 participants
@gewarren @mairaw @BillWagner @dotnet-bot