Skip to content

9). Add topic files 11 to 14 #17022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

jameshkramer
Copy link
Contributor

@jameshkramer jameshkramer commented Feb 8, 2020

@mairaw
This PR is for user story #1576037.

It adds four topic files, makes corresponding deletions from the C# and VB folders, and adds redirection entries.

cc: @tfosmark

Contributes to #4728

@pkulikov
Copy link
Contributor

pkulikov commented Feb 8, 2020

@jameshkramer should this and #17021 target the linq-to-xml branch, not master?

@jameshkramer
Copy link
Contributor Author

@pkulikov, yes, sorry. I'll fix.

@jameshkramer jameshkramer changed the base branch from master to linq-to-xml February 10, 2020 17:58
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Feb 10, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jameshkramer. I've left you some comments to address before we can merge, Let me know if you have any questions or if you need any help.

ms.assetid: 81e5686c-9658-42d8-a7e3-b11be0a2c98b
---

# How to parse a string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# How to parse a string
# How to parse a string (LINQ to XML)

@@ -0,0 +1,204 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not connected to the TOC but I think if you rename the file as I'm suggesting to you, that would fix the problem

@jameshkramer jameshkramer force-pushed the br9-add-topic-files-11-to-14 branch 2 times, most recently from f7d5142 to ee2e253 Compare February 12, 2020 21:29
@jameshkramer jameshkramer reopened this Feb 12, 2020
@jameshkramer jameshkramer force-pushed the br9-add-topic-files-11-to-14 branch from ee2e253 to 5b34205 Compare February 12, 2020 22:08
@jameshkramer jameshkramer force-pushed the br9-add-topic-files-11-to-14 branch from b748ede to 1d903da Compare February 12, 2020 23:22
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @jameshkramer!

@mairaw mairaw merged commit 3b0a22f into dotnet:linq-to-xml Feb 26, 2020
@jameshkramer jameshkramer deleted the br9-add-topic-files-11-to-14 branch April 22, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-csharp/svc dotnet-visualbasic/svc vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants