Skip to content

Conversation

jameshkramer
Copy link
Contributor

@jameshkramer jameshkramer commented Feb 15, 2020

@mairaw
This PR is for user story #1576037.

It adds four topic files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. There are also minor fixes to a few other files.

cc: @tfosmark

Contributes to #4728

@dotnet-bot dotnet-bot added this to the February 2020 milestone Feb 15, 2020
@jameshkramer jameshkramer force-pushed the br10-add-topic-files-15-to-18 branch 2 times, most recently from c4434f8 to de825b7 Compare February 18, 2020 22:25
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Feb 19, 2020
@BillWagner
Copy link
Member

Thanks @jameshkramer I gave this a good review today. A few comments:

First, there are a number of warnings for the additions in the new TOC in the standard folder.
Second, and possibly @mairaw can provide more insight here. What's the reason behind not removing nodes from the articles that are moving and consolidating?

Otherwise, it looks great.

@mairaw
Copy link
Contributor

mairaw commented Feb 24, 2020

I'll try to get this reviewed later today. I think we can have a separate PR that removes the entire nodes from the previous locations. We usually have some warnings happening until all articles are merged but I believe this one has some extra ones that need to be dealt with before merging.

@pkulikov
Copy link
Contributor

@mairaw this PR is not intended for the master and should be retargered?

@jameshkramer jameshkramer changed the base branch from master to linq-to-xml February 24, 2020 21:00
@jameshkramer
Copy link
Contributor Author

@pkulikov, yes, sorry, the target should be linq-to-xml, not master, and I have now corrected it. I wonder when I will stop making this mistake.

cc: @mairaw, @BillWagner

@jameshkramer
Copy link
Contributor Author

@BillWagner @mairaw

Bill, thanks for reviewing these. I'm glad you find them suitable. Maira, I appreciate you're taking a look also.

I'll look at the redirection warnings.

I plan three more PRs this week, with 12 more articles.

@jameshkramer
Copy link
Contributor Author

Apparently the great majority of the warnings are for "file not found", because the TOC refers to files that haven't been merged yet. These will be fixed over time. However the first four are "redirection url found conflict", and the message says "appears twice or more in the redirection mappings". It seems these result from there being redirections to the merged file in /standard from both the C# and the VB versions. Do we need to do something here, or just ignore the messages?

@mairaw
Copy link
Contributor

mairaw commented Feb 24, 2020

Some of the warnings will still have to be corrected like
"The '/dotnet/standard/linq/catch-parsing-errors' appears twice or more in the redirection mappings"

@jameshkramer
Copy link
Contributor Author

But what is the fix? I thought we wanted both the C# and the VB versions to be redirected to the merged version.

@jameshkramer jameshkramer force-pushed the br10-add-topic-files-15-to-18 branch from de825b7 to 3465c20 Compare February 25, 2020 21:27
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jameshkramer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-csharp/svc dotnet-visualbasic/svc vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants