Skip to content

Conversation

OliaG
Copy link
Contributor

@OliaG OliaG commented Mar 3, 2020

This supersedes #17258, with the difference that I'm issuing the PR from a branch in dotnet/docs, rather than my fork.

@BillWagner BillWagner modified the milestones: March 2020, April 2020 Apr 2, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of comments

OliaG and others added 2 commits April 7, 2020 15:50
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@OliaG
Copy link
Contributor Author

OliaG commented Apr 10, 2020

@mairaw All review comments are addressed

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments... also there are still some comments from my previous review still unresolved (they are marked as outdated but still valid)

First, you should check in the following link whether the Windows 10 API that
you'll use requires a Package Identity:

<https://docs.microsoft.com/windows/apps/desktop/modernize/desktop-to-uwp-supported-api>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these bare links, is it important that they show up in print? otherwise, I'd recommend adding the title too for SEO purposes and better readability


WPF or Windows Forms developers don't usually deal with HWND inside their code,
so it may be hard to understand and handle HWND pointers and the underlying
wiring stuff to communicate Win32 and UWP worlds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace stuff with something else? Sounds too informal

OliaG and others added 3 commits April 23, 2020 19:39
@mairaw mairaw closed this Apr 26, 2020
@mairaw mairaw reopened this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants