-
Notifications
You must be signed in to change notification settings - Fork 6k
Desktop e-book: Chapter 4 #17302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop e-book: Chapter 4 #17302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First set of comments
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@mairaw All review comments are addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments... also there are still some comments from my previous review still unresolved (they are marked as outdated but still valid)
First, you should check in the following link whether the Windows 10 API that | ||
you'll use requires a Package Identity: | ||
|
||
<https://docs.microsoft.com/windows/apps/desktop/modernize/desktop-to-uwp-supported-api> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For these bare links, is it important that they show up in print? otherwise, I'd recommend adding the title too for SEO purposes and better readability
|
||
WPF or Windows Forms developers don't usually deal with HWND inside their code, | ||
so it may be hard to understand and handle HWND pointers and the underlying | ||
wiring stuff to communicate Win32 and UWP worlds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we replace stuff with something else? Sounds too informal
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
This supersedes #17258, with the difference that I'm issuing the PR from a branch in dotnet/docs, rather than my fork.