Skip to content

Move base-types TOC into parent TOC #17650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2020
Merged

Move base-types TOC into parent TOC #17650

merged 3 commits into from
Mar 31, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 31, 2020 •
edited
Loading

  • Combine base-types TOC into parent /standard/toc.yml (prep for new landing page so it doesn't lead you out of the current TOC)
  • Format tables under examples section of regular-expressions.md.
  • Delete unnecessary parent topics and add redirects.
  • Minor formatting improvements to some files.

Internal preview link.

@dotnet-bot dotnet-bot added this to the April 2020 milestone Mar 31, 2020
@gewarren gewarren marked this pull request as ready for review March 31, 2020 01:07
@gewarren gewarren requested review from a team and Thraka as code owners March 31, 2020 01:07
gewarren
gewarren commented Mar 31, 2020
View reviewed changes
docs/standard/base-types/regular-expressions.md
The <xref:System.String> class includes a number of string search and replacement methods that you can use when you want to locate literal strings in a larger string. Regular expressions are most useful either when you want to locate one of several substrings in a larger string, or when you want to identify patterns in a string, as the following examples illustrate.

> [!TIP]
> The <xref:System.Web.RegularExpressions> namespace contains a number of regular expression objects that implement predefined regular expression patterns for parsing strings from HTML, XML, and ASP.NET documents. For example, the <xref:System.Web.RegularExpressions.TagRegex> class identifies start tags in a string and the <xref:System.Web.RegularExpressions.CommentRegex> class identifies ASP.NET comments in a string.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought this over from the regular-expression-examples.md file that I deleted.

BillWagner
BillWagner approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren
Copy link
Contributor Author

Thanks for the review, Bill!

@gewarren gewarren merged commit dd41b61 into dotnet:master Mar 31, 2020
@gewarren gewarren deleted the standard-toc branch March 31, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@Thraka Thraka Awaiting requested review from Thraka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

April 2020

Development

Successfully merging this pull request may close these issues.

3 participants

@gewarren @BillWagner @dotnet-bot