Skip to content

Conversation

cxwtool
Copy link
Contributor

@cxwtool cxwtool commented Apr 15, 2020

Please don't squash-merge this PR.

Cam Soper and others added 16 commits April 13, 2020 19:47
The narrative is about building a Netcore 3.1 app, but the sample showed 2.2.
…the C# compiler, including nullable analysis (#17776)

* Create outlines for new content

- update TOC
- Add stub outlines for new content.

* port global attribute content

* port general attributes

- Add description for general attributes
- Move samples from /samples/snippets
- Add interactivity where possible.

* remove links, move existing content.

* fix a build warning

* fix warnings

* off by one folder

* finished updating caller information

* move existing nullable attribute content

Also, update the title of the existing content

* proofread and add new attributes

* fix titles

* Apply suggestions from code review

Co-Authored-By: Petr Kulikov <petr.kulikov@gmail.com>

* fix build warnings.

Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com>
* Updated documentation with the path where xsd can be found

* Fixed linter issues

* Update docs/standard/serialization/xml-schema-def-tool-gen.md

Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>

* Update xml-schema-def-tool-gen.md

Co-authored-by: Andy De George <2672110+Thraka@users.noreply.github.com>
* Updated documentation with the path where xsd can be found

* Update docs/standard/serialization/xml-schema-definition-tool-xsd-exe.md

Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com>

Co-authored-by: Andy De George <2672110+Thraka@users.noreply.github.com>
The line-referencing has an off-by-one error.
* update add web reference instructions
* Add IAsyncEnumerable

Fixes #16634

This commit: Add that `IAsyncEnumerable<T>` is a valid return type for an async method. Add a new project and sample code for IAsyncEnumerable.

* grammar cleanup

In this commit, fix style issues and remove unused anchors. (Those anchors were added during migration).

* move sample files

This commit moves the old snippet files without any changes.

* this commit migrates the samples

The existing sample code was in the /samples folder. This commit moves those into the ./snippets folder, and adapts the includes to use the (new) preferred syntax.

* fix typo

* Apply suggestions from code review

Co-Authored-By: Tom Dykstra <tdykstra@microsoft.com>

* respond to additional feedback.

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Removed old ASR link, added VM migration links
In my previous edit, several of the label names had an extra space. This PR removes them.
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 15, 2020
@BillWagner BillWagner merged commit c91110e into live Apr 15, 2020
@BillWagner BillWagner deleted the publish-29503 branch April 15, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.