fix: MD034/no-bare-urls #18470
Merged
fix: MD034/no-bare-urls #18470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
requested review from
gewarren,
HongGit,
karelz,
luisquintanilla,
mamccrea,
nishanil,
shirhatti,
Thraka and
a team
as code owners
Thraka
reviewed
May 18, 2020
Youssef1313
reviewed
May 18, 2020
.../framework/wcf/feature-details/creating-multicasting-applications-using-the-udp-transport.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
May 18, 2020
| This change doesn't apply to all binaries referenced via `Microsoft.AspNetCore.App` in ASP.NET Core 2.x. Notable exceptions include: | ||
|
|
||
| - `Microsoft.Extensions` libraries that continue to target .NET Standard will be available as NuGet packages (see https://github.com/dotnet/extensions). | ||
| - `Microsoft.Extensions` libraries that continue to target .NET Standard will be available as NuGet packages (see <https://github.com/dotnet/extensions>). |
There was a problem hiding this comment.
Not related to the changes, but it seems that "will be" should be changed to "are".
There was a problem hiding this comment.
Yeah, it seems like the whole document is written in the future. I'll leave that up to a real tech writer to fix separately :)
BillWagner
added
dotnet-spark/svc
dotnet-ml/svc
dotnet-architecture/svc
dotnet-framework/svc
dotnet-core/prod
grpc/subsvc
modernize-with-azure-containers/aubsvc
cloud-native/subsvc
microservices/subsvc
wf/subsvc
wpf/subsvc
wcf/subsvc
winforms/subsvc
networking/subsvc
and removed
📚 Area - .NET for Apache Spark Guide
labels
poke
added a commit
to poke/dotnet_docs
that referenced
this pull request
Oct 31, 2021
Since the changes were already made in the past, adjust the wording to document the current state instead of hinting at a planned future. Fixes dotnet#18470.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are still some other instances in things like
[!VIDEOelements, so the rule wasn't turned on in.markdownlint.jsonwith this