Skip to content

Conversation

shankargurav
Copy link
Contributor

Explanation on how to do it using Visual Studio

Summary

Describe your changes here.

Fixes #11647 (if available)

shankargurav and others added 4 commits May 24, 2020 18:57
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update @shankargurav

I had a couple suggestions, and then this is ready to merge.

@BillWagner BillWagner modified the milestones: May 2020, June 2020 Jun 4, 2020
@BillWagner
Copy link
Member

@shankargurav Can you accept the remaining suggestion? Then, this is ready to merge.

@IEvangelist IEvangelist modified the milestones: June 2020, July 2020 Jul 6, 2020
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
@shankargurav
Copy link
Contributor Author

@shankargurav Can you accept the remaining suggestion? Then, this is ready to merge.

yes, I think it should be ok now.

Copy link
Contributor Author

@shankargurav shankargurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@shankargurav shankargurav requested a review from BillWagner July 21, 2020 16:32
@BillWagner
Copy link
Member

@shankargurav I apologize for missing those last updates. I approved your PR, and I'll :shipit: now.

@BillWagner BillWagner merged commit 187c207 into dotnet:master Jul 27, 2020
@shankargurav
Copy link
Contributor Author

@shankargurav I apologize for missing those last updates. I approved your PR, and I'll :shipit: now.

Np! thanks @BillWagner for PR review and approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient information to run command to add external alias
5 participants