Skip to content

Conversation

guardrex
Copy link
Contributor

@guardrex guardrex commented Apr 12, 2017

@rpetrusha ... ok, this one is ready for review+merge.

@guardrex guardrex removed the WIP label Apr 12, 2017
The .NET Framework is constantly evolving and in order to improve cross-platform development or to introduce new functionality early to our customers, we release new features out of band (OOB). This topic lists the OOB projects that we provide documentation for.

In addition, some libraries target specific platforms or implementations of the .NET Framework. For example, the
[CodePagesEncodingProvider Class](CodePagesEncodingProvider.xml) class makes code page encodings available to UWP apps developed using the .NET Framework. This topic lists these libraries as well.
In addition, some libraries target specific platforms or implementations of the .NET Framework. For example, the [CodePagesEncodingProvider Class](https://msdn.microsoft.com/library/system.text.codepagesencodingprovider.aspx) class makes code page encodings available to UWP apps developed using the .NET Framework. This topic lists these libraries as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've duplicated class here (Class and class). Best to leave "Class" out of the link text.

|<xref:System.Text.CodePagesEncodingProvider>|Extends the <xref:System.Text.EncodingProvider> class to make code page encodings available to apps that target the Universal Windows Platform.|
| Project | Description |
| ------- | ----------- |
| [System.Text.CodePagesEncodingProvider](https://msdn.microsoft.com/library/system.text.codepagesencodingprovider.aspx) | Extends the <xref:System.Text.EncodingProvider> class to make code page encodings available to apps that target the Universal Windows Platform. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code pages encoding provider exists in the API Browser, so it should be renderable as a link. Did xref:System.Text.CodePagesEncodingProvider not resolve?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't resolve the first time. I'll double-check and confirm it works/breaks.

| ------- | ----------- |
| [System.Collections.Immutable](https://msdn.microsoft.com/library/system.collections.immutable.aspx) | Provides collections that are thread safe and guaranteed to never change their contents. |
| [System.Net.Http.WinHttpHandler](http://go.microsoft.com/fwlink/p/?LinkId=624833) | Provides a message handler for <xref:System.Net.Http.HttpClient> based on the WinHTTP interface of Windows. |
| <xref:System.Numerics> | Provides a library of vector types that can take advantage of SIMD hardware-based acceleration.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that we have to link to the .NET Core package rather than a general one. I think that we need to do this as System.Numerics.Vectors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it ... https://docs.microsoft.com/en-us/dotnet/api/system.numerics.vector?view=netcore-1.1.0

I'll try again. I thought it failed the first time, but I may have been trying to link it as System.Numerics.Vectors%601.

-->
| Project | Description |
| ------- | ----------- |
| [System.Collections.Immutable](https://msdn.microsoft.com/library/system.collections.immutable.aspx) | Provides collections that are thread safe and guaranteed to never change their contents. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My internet connection is down, but this should exist as a NuGet package that's part of .NET Core. So it should exist on docs.

@guardrex
Copy link
Contributor Author

@rpetrusha If that Vector class destination is good, I think we're ok now with this one.

| Project | Description |
| ------- | ----------- |
| <xref:System.Collections.Immutable> | Provides collections that are thread safe and guaranteed to never change their contents. |
| [System.Net.Http.WinHttpHandler](http://go.microsoft.com/fwlink/p/?LinkId=624833) | Provides a message handler for <xref:System.Net.Http.HttpClient> based on the WinHTTP interface of Windows. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than an fwlink, this should link to WinHttpHandler on docs. If xref:System.Net.Http.WinHttpHandler doesn't work, it's found in ../../xml/System.Net.Http/WinHttpHandler.xml.

| <xref:System.Collections.Immutable> | Provides collections that are thread safe and guaranteed to never change their contents. |
| [System.Net.Http.WinHttpHandler](http://go.microsoft.com/fwlink/p/?LinkId=624833) | Provides a message handler for <xref:System.Net.Http.HttpClient> based on the WinHTTP interface of Windows. |
| <xref:System.Numerics.Vector> | Provides a library of vector types that can take advantage of SIMD hardware-based acceleration.|
| [TPL Dataflow Library](../../../docs/standard/parallel-programming/dataflow-task-parallel-library.md) | The TPL Dataflow Library provides dataflow components to help increase the robustness of concurrency-enabled applications. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a link to the API reference. Try xref:System.Threading.Tasks.Dataflow. The dataflow library is in GitHub.

| ------- | ----------- |
| <xref:System.Collections.Immutable> | Provides collections that are thread safe and guaranteed to never change their contents. |
| [System.Net.Http.WinHttpHandler](http://go.microsoft.com/fwlink/p/?LinkId=624833) | Provides a message handler for <xref:System.Net.Http.HttpClient> based on the WinHTTP interface of Windows. |
| <xref:System.Numerics.Vector> | Provides a library of vector types that can take advantage of SIMD hardware-based acceleration.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct, Vector is a single type, not the set of types found in the OOB NuGet package.
I had thought we just needed to link to the System.Numerics namespace with the .NET Core filter set, but that includes BigInteger, which isn't part of the OOB release. Unfortunately, I can't think of a solution to this issue other than linking to the MSDN page, which is what you'd done originally. We'd need new feature work done to support specific OOB packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetrusha rpetrusha merged commit 5b8db2b into dotnet:master Apr 14, 2017
@guardrex guardrex deleted the guardrex/additional-apis-update branch April 14, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants