-
Notifications
You must be signed in to change notification settings - Fork 6k
VS Mac .NET Core tutorials #18819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
VS Mac .NET Core tutorials #18819
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ee7cf55
draft
tdykstra 95e894e
draft
tdykstra 51b8b00
draft
tdykstra 13c3f52
draft
tdykstra 0e188e2
draft
tdykstra e088475
draft
tdykstra 3aee193
draft
tdykstra 91754bb
draft
tdykstra ba3f819
add missing image
tdykstra 7cc1709
make create app tutorials consistent
tdykstra b787bc9
make debug tutorials consistent
tdykstra 3f0e77f
make publish tutorials consistent
tdykstra a08d5dd
make library tutorials consistent
tdykstra b3ef48f
make testing tutorials consistent
tdykstra 9f6e90c
markdownlint
tdykstra e3361a2
fix add ref steps
tdykstra 8a9a767
proofread pass
tdykstra 8245c3b
proofread pass
tdykstra 2c72cf2
reformat ctrl-click
tdykstra d70aeca
standardize keyboard formatting
tdykstra 904b225
change key representations
tdykstra 8afd4a2
more key representations
tdykstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what is the reason not to use
<kbd>
here? I ask because I use it everywhere and now I'm wondering if I shouldn't.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ctrl-click seems to be a special case mixing keyboard and mouse, so I decided to leave it the way it was in the Mac tutorials as they already existed. I'm happy to change if you've seen Mac tutorials using
<kbd>Ctrl</kbd>-click
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @BillWagner on how best to render control-click for macOS in tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. I don't have a clear recommendation. I think the
<kbd>Ctrl</kbd>-click
is best.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A related issue: given that Macs have keyboard labels all in lowercase (enter, control, option, command, etc., should those keys be represented by, e.g.,
<kbd>command</kbd>
or<kbd>Command</kbd>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with the earlier question, I don't have an answer here. I think we will set the standard.
My weakly held proposal: go with lower case to match the keyboard labels.