Skip to content

Corrected description of ExpressionVisitor.VisitAndConvert #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

svick
Copy link
Contributor

@svick svick commented Apr 14, 2017

The original description of this overload was worded as if the collection operated on a single expression. But it operates on a collection of expressions, so I have updated the documentation to reflect that.

I have also noticed that many methods in this file have <remarks>To be added.</remarks>. Are they useful to track missing documentation, or should they just be removed?

@rpetrusha
Copy link
Contributor

Thanks for fixing noticing and fixing this longstanding issue, @svick. These changes look good.

In terms of <remarks>To be added.</remarks>, the boilerplate was evidently added when a remarks tag was present in documents in our old authoring system but there was no content. The build appears to ignore "To be added" remarks, and a search shows that <remarks> with "To be added." as the content appears in 12,280 additional topics. So I don't think that there's anything to be gained by asking you to remove them from this file.

So I'll approve and close your PR. Again, thanks for submitting it.

@rpetrusha rpetrusha merged commit a8cd6ab into dotnet:master Apr 14, 2017
@svick svick deleted the patch-5 branch April 14, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants