Skip to content

Deserialize rewraps exceptions #19764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2020
Merged

Deserialize rewraps exceptions #19764

merged 3 commits into from
Jul 31, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 30, 2020 •
edited
Loading

Fixes #19604. Adds new "serialization" category. Deletes existing preview-to-preview serialization breaking change for .NET Core 3.0.

Preview link.

@gewarren gewarren requested a review from a team as a code owner July 30, 2020 22:25
@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 30, 2020
@gewarren
Copy link
Contributor Author

gewarren commented Jul 30, 2020 •
edited
Loading

@GrabYourPitchforks Does the exception info need to be updated in the API reference?

gewarren
gewarren commented Jul 30, 2020
View reviewed changes
@GrabYourPitchforks
Copy link
Member

@gewarren If we wanted to update the API docs, we could strike:

The target type is a Decimal, but the value is out of range of the Decimal type.

And instead put:

"The input stream does not represent a well-formed BinaryFormatter serialized payload, or an error occurred while deserializing an object from the input stream. The SerializationException.InnerException property may contain more information about the root cause."

BillWagner
BillWagner approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. You can :shipit: when ready.

@gewarren gewarren merged commit 9d6b813 into dotnet:master Jul 31, 2020
@gewarren gewarren deleted the serializationexception-bc branch July 31, 2020 17:09
@gewarren
Copy link
Contributor Author

Thanks for the reviews Bill and Levi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

July 2020

Development

Successfully merging this pull request may close these issues.

Breaking change: BinaryFormatter.Deserialize rewraps some exceptions in SerializationException

4 participants

@gewarren @GrabYourPitchforks @BillWagner @dotnet-bot