-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove+redirect framework/deployment docs to /install with updates #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
guardrex
commented
Apr 21, 2017
- Remove+redirect framework/deployment docs
- Minor grammar+style updates
- Fix layout (remove stray spaces, fix tables, etc.)
Updates
We also need an entry from the main TOC to the Installation Guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! left a few comments in addition to the main TOC request I made earlier.
## Unsupported Windows versions | ||
|
||
- [Windows XP](on-windows-xp.md) | ||
- [Windows XP](on-windows-xp.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since now this is the main entrance to installation, it also needs to be changed to point to the for developers guide. I'd also remove the intro and the first sub-header, since they don't seem to add much value.
docs/framework/install/toc.md
Outdated
## [Running .NET Framework 1.1 Apps on Windows 8, Windows 8.1, or Windows 10](run-net-framework-1-1-apps.md) | ||
## [Install the .NET Framework 3.5 on Windows 10, Windows 8.1, and Windows 8](dotnet-35-windows-10.md) | ||
## [Troubleshooting the installation of the .NET Framework 3.5 on Windows 8, Windows 8.1, and Windows 10](net-framework-3-5-on-windows-8-plus.md) | ||
## [Installing the .NET Framework](guide-for-developers.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ing from the titles (general comment, not just here). In this particular case, the title should be changed to something different since the index.md file is now the Installing the .NET Framework topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mairaw Rename Installing the .NET Framework (guide-for-developers.md) 👉 Install the .NET Framework for developers?
docs/framework/install/toc.md
Outdated
## [Install the .NET Framework 3.5 on Windows 10, Windows 8.1, and Windows 8](dotnet-35-windows-10.md) | ||
## [Troubleshooting the installation of the .NET Framework 3.5 on Windows 8, Windows 8.1, and Windows 10](net-framework-3-5-on-windows-8-plus.md) | ||
## [Installing the .NET Framework](guide-for-developers.md) | ||
## [Installing the .NET Framework on Windows 10](on-windows-10.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move these topics to the top of the TOC
docs/framework/install/toc.md
Outdated
## [Installing the .NET Framework 3.5 on Windows 8 and later versions](net-framework-3-5-on-windows-8-plus.md) | ||
## [Running .NET Framework 1.1 Apps on Windows 8 and later versions](run-net-framework-1-1-apps.md) | ||
## [Troubleshooting](troubleshoot-blocked-installations-and-uninstallations.md) | ||
## [Running .NET Framework 1.1 Apps on Windows 8, Windows 8.1, or Windows 10](run-net-framework-1-1-apps.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be the last entry
docs/framework/install/toc.md
Outdated
## [Troubleshooting](troubleshoot-blocked-installations-and-uninstallations.md) | ||
## [Running .NET Framework 1.1 Apps on Windows 8, Windows 8.1, or Windows 10](run-net-framework-1-1-apps.md) | ||
## [Install the .NET Framework 3.5 on Windows 10, Windows 8.1, and Windows 8](dotnet-35-windows-10.md) | ||
## [Troubleshooting the installation of the .NET Framework 3.5 on Windows 8, Windows 8.1, and Windows 10](net-framework-3-5-on-windows-8-plus.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it a child of install
tocHref: /dotnet/articles/framework/deployment/ | ||
topicHref: /dotnet/articles/framework/deployment/index | ||
items: | ||
- name: Installing the .NET Framework on Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the same entry for the install folder, we should change this to Installation Guide
|
||
# Troubleshooting the installation of the .NET Framework 3.5 on Windows 8, Windows 8.1, and Windows 10 | ||
|
||
During installation you may encounter error 0x800f0906, 0x800f0907, or 0x800f081f, in which case refer to [.NET Framework 3.5 installation error: 0x800f0906, 0x800f0907, or 0x800f081f](https://support.microsoft.com/en-us/kb/2734782). Note that these are possibly resolved by installing [security update 3005628](https://support.microsoft.com/kb/3005628). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link to the kb article 2734782 is not what i expected. i think we need to link to https://support.microsoft.com/en-us/help/2734782/.net-framework-3.5-installation-error-0x800f0906,-0x800f081f,-0x800f0907.
|
||
During installation you may encounter error 0x800f0906, 0x800f0907, or 0x800f081f, in which case refer to [.NET Framework 3.5 installation error: 0x800f0906, 0x800f0907, or 0x800f081f](https://support.microsoft.com/en-us/kb/2734782). Note that these are possibly resolved by installing [security update 3005628](https://support.microsoft.com/kb/3005628). | ||
|
||
If the installation fails or you don't have an Internet connection, it's necessary to use your Windows installation media. For details, see Method 3 for error 0x800f0906 in the [.NET Framework 3.5 installation error article](https://support.microsoft.com/en-us/kb/2734782). If you don't have installation media, see [Create Installation media for Windows 8.1](http://windows.microsoft.com/en-US/windows-8/create-reset-refresh-media?woldogcb=0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here for kb article.
@mairaw The last set of changes is extensive in attempting to realign link titles with changed doc names (e.g., dropping "-ing" and changing "Installation Guide" where it pointed to the guide for developers). I've temporarily used the title Install the .NET Framework for developers for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There also needs to be an entry for the Installation Guide from the main TOC under framework.
docs/framework/get-started/index.md
Outdated
|[.NET Core and Open-Source](../../../docs/framework/get-started/net-core-and-open-source.md)|Describes what .NET Core is in relation to the .NET Framework and how to access the open-source .NET Core projects.| | ||
|[.NET Core documentation](https://docs.microsoft.com/dotnet/)|The conceptual and API reference documentation for .NET Core.| | ||
|[Installation Guide](../../../docs/framework/install/guide-for-developers.md)|Provides information about installing the .NET Framework.| | ||
|[Install the .NET Framework for developers](../../../docs/framework/install/guide-for-developers.md)|Provides information about installing the .NET Framework.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change this to point to the new installation guide (index.md)
docs/framework/get-started/index.md
Outdated
|[Install the .NET Framework for developers](../../../docs/framework/install/guide-for-developers.md)|Provides information about installing the .NET Framework.| | ||
|
||
## See Also | ||
[.NET Framework 4.6 and 4.5](../../../docs/framework/index.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe for another PR but this string (.NET Framework 4.6 and 4.5) should be removed from the docs - I've seen it a few times. We should now call it .NET Framework Guide IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened for work at #2094
|
||
> [!NOTE] | ||
> For a general introduction to the .NET Framework for both users and developers, see [Getting Started](../../../docs/framework/get-started/index.md). To download the .NET Framework, see [Installation Guide](../../../docs/framework/install/guide-for-developers.md). | ||
> For a general introduction to the .NET Framework for both users and developers, see [Getting Started](../../../docs/framework/get-started/index.md). To download the .NET Framework, see [Install the .NET Framework for developers](../../../docs/framework/install/guide-for-developers.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here - change the link to the index file instead of changing the link text
The tables in this topic provide the hardware, operating system, and software requirements for the .NET Framework 4.5 and its point releases (4.5.1 and 4.5.2), the [!INCLUDE[net_v46](../../../includes/net-v46-md.md)] and its point releases (4.6.1 and 4.6.2), and the .NET Framework 4.7. Development environments that enable you to develop applications for the .NET Framework have a separate set of requirements. | ||
|
||
For download information and links, see [Installation Guide](../../../docs/framework/install/guide-for-developers.md). | ||
For download information and links, see [Install the .NET Framework for developers](../../../docs/framework/install/guide-for-developers.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, change link to index.md instead of changing link text. review where you made this change to see whether it makes sense to go to the developer's one or the general one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These preexisted the PR pointing to guide-for-developers.md, which is why I didn't consider changing them (i.e., I trusted the author of the topic). I'll search and take a closer 👀 look at where the guide for devs is linked.
[EDIT] Took a look. I removed one link to the dev version where the getting started index page is linked. The getting started index page delineates user vs. dev info and links, so that link to the guide for developers wasn't necessary. Otherwise, the other topics look dev-ish in nature.
@richlander @rpetrusha with the release of .NET 4.7, do we need to make updates to the new Windows install pages to include 4.7? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guardrex! It will be important to get this one merged. This set is probably due now for another update with the release of .NET Framework 4.7, but let's address that on a separate PR. I've made a few fixes to the TOC structure.
Update framework/deployment topics for 4.7 issue created. |
We only change the ms.date if we made sure that the actual content of the topic is accurate and relevant. I don't think that's the case in this particular PR given that we haven't added 4.7, for example. |
ok ... I'll revert those. |