Async Refactor #199
Closed
Async Refactor #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/async/async-in-depth.md
Outdated
There was a problem hiding this comment.
Suggestion:
Writing I/O-Bound or CPU-Bound asynchronous code is simple using the
asyncandawaitkeywords. The two key types involved areTaskandTask<T>. This document explains the fairly complex machinery that is used under the covers to provide that great experience.
There was a problem hiding this comment.
Not too sure how I feel about the very end, selling the great experience. At the point where people read this document, I think they're already pretty much sold on the idea of using async/await.
Otherwise, I like the change.
|
Left a bunch of comments on the first doc. I figure we'll get that one fully sorted out before spending time on the C# one. |
Merged
|
Closing as the PR for this is now #214 |
gewarren
referenced
this pull request
in gewarren/docs
Jul 14, 2020
Merge public live into private master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #176 and #69.
The previous set of async articles had a focus which no longer works with the current TOC and overall set of principles. I've augmented the async file under the C# tutorials to now have a focus on how to write async code in C# (both I/O and CPU-bound code). There are some links to a more in-depth article which contains deeper dives into the
TaskandTask<T>types, explains how they're relevant for client/server scenarios, and some more potential deeper information.Current issues to be addressed:
/cc @richlander @BethMassi @blackdwarf @mairaw @stevehoag @matthewreily