-
Notifications
You must be signed in to change notification settings - Fork 6k
Enhance Trim Deploy Documentation #20135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iving more context. The primary changes are in the “Trim self-contained deployments and executables” page to clarify why this is still a preview feature. Also added some details for the 2 flags for trimming with an emphasis to set these via configuration files (project or publish profile) with a link to the github doc page where all the flags are specified.
Youssef1313
reviewed
Aug 17, 2020
Youssef1313
reviewed
Aug 17, 2020
tdykstra
reviewed
Aug 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left some rephrasing suggestions.
danroth27
reviewed
Aug 18, 2020
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Thanks for mentioning FDD! Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Daniel Roth <daroth@microsoft.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
tdykstra
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding more information for the trim deployment (PublishTrimmed) by giving more context. The primary changes are in the “Trim self-contained deployments and executables” page to clarify why this is still a preview feature. Also added some details for the 2 flags for trimming with an emphasis to set these via configuration files (project or publish profile) with a link to the github doc page where all the flags are specified.
Fixes #Issue_Number (if available)