Fix Missing .NET API documentation #2046
Conversation
|
@daxianji007, It will cover your contributions to all .NET Foundation-managed open source projects. |
| @@ -1,41 +1,23 @@ | |||
| --- | |||
| uid: System.Text.DecoderFallback | |||
| author: "rpetrusha" | |||
There was a problem hiding this comment.
why are these metadata values being removed?
|
@daxianji007, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Thanks for signing the CLA @daxianji007. In addition to my previous question, we also have build errors. Is that something you can take care of? |
|
@mairaw, I have updated the pull request:
|
xml/ns-System.Text.xml
Outdated
| @@ -1,6 +1,6 @@ | |||
| <Namespace Name="System.Text"> | |||
| <Docs> | |||
| <summary>The <see cref="N:System.Text" /> namespace contains classes that represent ASCII and Unicode character encodings; abstract base classes for converting blocks of characters to and from blocks of bytes; and a helper class that manipulates and formats <see cref="T:System.String" /> objects without creating intermediate instances of <see cref="T:System.String" />.</summary> | |||
| <summary>The <see cref="N:System.Text" /> namespace in the System.Text.Encoding.CodePages.dll assembly contains a single class, <see cref="T:System.Text.CodePagesEncodingProvider" />, that extends the <see cref="T:System.Text.EncodingProvider" /> class to make code page encodings available to apps that target the Universal Windows Platform.</summary> | |||
There was a problem hiding this comment.
@rpetrusha now that we'll only have a single namespace page for this, do you want to merge their content or leave the original one?
There was a problem hiding this comment.
@mairaw, Here I think that we want to leave the original one.
xml/ns-System.Numerics.xml
Outdated
| @@ -1,6 +1,6 @@ | |||
| <Namespace Name="System.Numerics"> | |||
| <Docs> | |||
| <summary>The <see cref="N:System.Numerics" /> namespace contains numeric types that complement the numeric primitives, such as <see cref="T:System.Byte" />, <see cref="T:System.Double" />, and <see cref="T:System.Int32" />, that are defined by the .NET Framework.</summary> | |||
| <summary>Provides a set of SIMD-enabled vector types.</summary> | |||
There was a problem hiding this comment.
should we leave the original here @rpetrusha?
There was a problem hiding this comment.
@mairaw, Yes, the original one. Except for one type not in the .NET Framework, the .NET Framework SIMD documentation is identical to the .NET Core documentation.
|
Thanks @daxianji007. There seems to be still some missing content that should have come with this migration. For example, the explicit operators for Their docs do exist in CAPS: |
|
@mairaw , I fixed a bug that cause these missing Vector contents and had a re-migration. |
Fix Missing .NET API documentation: https://mseng.visualstudio.com/VSChina/_workitems?id=979781
Fixes #1993