Skip to content

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Sep 11, 2020

Some of the redirects are throwing errors. Unsure why it happens on some and not others...

@adegeo adegeo requested a review from a team as a code owner September 11, 2020 17:50
@dotnet-bot dotnet-bot added this to the September 2020 milestone Sep 11, 2020
@adegeo adegeo requested review from BillWagner and removed request for a team September 11, 2020 17:51
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are conflicts, so I'll review once that's addressed.

@adegeo
Copy link
Contributor Author

adegeo commented Sep 14, 2020

I think I'll have to redo these. The conflicts are weird :)

@adegeo adegeo force-pushed the adegeo-fix-redirects branch from 53829da to 2cde599 Compare September 14, 2020 18:42
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now LGTM @adegeo

You can :shipit: when ready.

@adegeo adegeo merged commit 55d9368 into master Sep 14, 2020
@adegeo adegeo deleted the adegeo-fix-redirects branch September 14, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants