Small fixes to configure rule severity section #20779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dotnet_diagnostic` and `dotnet_analyzer_diagnostic` prefixes are only used for configuring rule severities that are respected by the compiler. Non-severity editorconfig options are defined and respected by each analyzer package themselves, so we cannot control the key format for these options.
mavasani
commented
Sep 25, 2020
mavasani
commented
Sep 25, 2020
gewarren
approved these changes
Sep 25, 2020
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
reviewed
Sep 25, 2020
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Sep 25, 2020
Nope, that is specific to the severity precedence rules enforced by the compiler. Compiler cannot enforce generic option precedence settings, those are up to each analyzer package/assembly to enforce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet_diagnosticanddotnet_analyzer_diagnosticprefixes are only used for configuring rule severities that are respected by the compiler. Non-severity editorconfig options are defined and respected by each analyzer package themselves, so we cannot control the key format for these options.