Skip to content

Add breaking change for preprocessor symbols #20848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

Add breaking change for preprocessor symbols #20848

merged 2 commits into from
Oct 1, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 30, 2020 •
edited
Loading

@gewarren gewarren requested a review from a team as a code owner September 30, 2020 17:52
@dotnet-bot dotnet-bot added this to the October 2020 milestone Sep 30, 2020
BillWagner
BillWagner approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

:shipit:

@gewarren gewarren merged commit f41023e into dotnet:master Oct 1, 2020
@gewarren gewarren deleted the netcoreapp3_1 branch October 1, 2020 15:47
@gewarren
Copy link
Contributor Author

gewarren commented Oct 1, 2020

Thanks Bill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.

Don't define NETCOREAPP3_1 when targeting .NET 5
3 participants
@gewarren @BillWagner @dotnet-bot