Skip to content

Add reference to .NET for Apache Spark open source repository #20883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Niharikadutta
Copy link
Contributor

We recently had a customer note how they couldn't find any official documentation linking to the .NET for Apache Spark github project https://github.com/dotnet/spark, so adding this to the preview note to establish the link.

@Niharikadutta Niharikadutta requested a review from a team as a code owner October 2, 2020 10:42
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 2, 2020
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit eff2385 into dotnet:master Oct 2, 2020
@Niharikadutta Niharikadutta deleted the nidutta/sparkdotnet_tutorial branch October 3, 2020 00:48
BillWagner pushed a commit that referenced this pull request Oct 5, 2020
* Refactor couple of code style rules to separate docs

Creating this initial PR as the proposed structure of IDE code style rule docs.
- Rule ID + option name based index
- We retain the rule ID-agnostic table based on just the option groups and option names in individual Language rules, Formatting rules and Naming rules pages. This could be a preferred browsing approach for users who just want to look at options, and don't care about rule severities, and hence rule IDs.
- All the rule specific content moves to separate `idexxxx.md` pages. Whenever multiple rules are used by the same option or an option group, we will create a single doc page, but have necessary id based redirects so the IDE analyzers themselves can use deterministic help links which end in `idexxxx`.

* Fix links

* Update docs/fundamentals/code-analysis/style-rules/index.md

* Update docs/fundamentals/code-analysis/style-rules/language-rules.md

* Fix table headers

* Rename file

* Rename column title

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Apply suggestions from code review

* Refactor out modifier preferences style rules and also restructure the toc reference a bit

* Fix links

* Try to fix build

* Remove quotes

* Refactor out Parentheses preferences - IDE0047 and IDE0048

* Update title for 'this and Me preferences' to make it consistent

* Update package index with latest published versions

* Port the remaining .NET style rules + address feedback

* Feedback

* Update docs/fundamentals/code-analysis/style-rules/ide0044.md

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Update docs/fundamentals/code-analysis/style-rules/ide0003-ide0009.md

* Update docs/fundamentals/code-analysis/style-rules/ide0036.md

* Add blank lines

* Add reference to .NET for Apache Spark open source repository (#20883)

* IDE0058 and IDE0059

* fix lint errors

* Replace default constructor with parameterless (#20873)

Contributes to the issue #11957

Updated the article "How to initialize objects by using an object
initializer". Replaced "default" constructor with "parameterless"
in the article itself and corresponding code snippets file.

* Fix typo in file name

* Fix links

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Address feedback

* Remove link

* Remove Option group column for the table and also adjust the Legend

* Replace `\_` with `_` in refactored rules

* Move entry up

* Fix table

* Fix typo

* Single file debugging (#20857)

* Add debugging section for single-file

* Styled file paths; changed link to relative

* Add more info about possible debugger errors

Hopefully this should come up in search engines if people encounter the errors

* Trailing space

Co-authored-by: Andy De George <67293991+adegeo@users.noreply.github.com>

* Fix counter name for HttpWebRequests Average Lifetime and Average Queue Time (#20874)

The counter  names HttpWebRequest Average Lifetime and HttpWebRequest Average Queue Time are incorrect. In Perfmon the counters are spelled with a HttpWebRequests being plural. The counters with a singular HttpWebRequest do not actualy exist.

Co-authored-by: Manish Vasani <mavasani@microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
Co-authored-by: Niharika Dutta <nidutta@microsoft.com>
Co-authored-by: Mykhailo <tmikent@gmail.com>
Co-authored-by: Cam Soper <cam.soper@microsoft.com>
Co-authored-by: Andy Gocke <angocke@microsoft.com>
Co-authored-by: Andy De George <67293991+adegeo@users.noreply.github.com>
Co-authored-by: brandonchastain <brandonchastain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants