Skip to content

Update delimiter for PackageTags #22151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Update delimiter for PackageTags #22151

merged 2 commits into from
Feb 1, 2021

Conversation

robbell
Copy link
Contributor

@robbell robbell commented Dec 24, 2020

Summary

Documentation says that PackageTags should be space delimited, but this conflicts with guidance on other pages and examples. I've updated the documentation to show that PackageTags should be semicolon-delimited.

Other documentation: https://docs.microsoft.com/en-us/dotnet/core/tools/csproj

Fixes #22150

@robbell
Copy link
Contributor Author

robbell commented Jan 12, 2021

I see the associated issue has now been triaged as a documentation bug. Will this PR be approved now?

@BillWagner BillWagner modified the milestones: December 2020, January 2021 Feb 1, 2021
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After that change, this is ready to merge.

@BillWagner BillWagner merged commit e5bdc8d into dotnet:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delimiter for PackageTags
3 participants