Skip to content

Conversation

sughosneo
Copy link

@sughosneo sughosneo commented Dec 29, 2020

This PR updates the following pages :

  • Index
  • Modernizing Desktop Apps on Windows 10 with .NET
  • Why modern desktop applications
  • What's new with .NET for Desktop?
  • Migrating Modern Desktop applications
  • Windows 10 migration
  • Example of migrating to .NET
  • Updates toc.yml for modernize ebook navigations.
  • Removes core word from the file name too.
  • Updates toc.yml for dotnet-architecture specific navigations.

@sughosneo sughosneo requested a review from OliaG as a code owner December 29, 2020 14:24
@sughosneo sughosneo requested a review from nishanil as a code owner December 29, 2020 14:32
@sughosneo sughosneo changed the title Updated content to net-5.0 Updates Modernizing Desktop eBook content to .net 5.0 Dec 30, 2020
@sughosneo sughosneo changed the title Updates Modernizing Desktop eBook content to .net 5.0 Updates Modernizing Desktop Apps eBook content to .net 5.0 Dec 30, 2020
@IEvangelist IEvangelist self-requested a review January 5, 2021 15:47
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions for improvements, thank you for this - great updates so far.

Sumit Ghosh and others added 11 commits January 6, 2021 16:47
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
…s.md

Co-authored-by: David Pine <david.pine@microsoft.com>
…s.md

Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Copy link
Contributor

@OliaG OliaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Left e few comments.

Sumit Ghosh and others added 5 commits January 7, 2021 10:55
Co-authored-by: Olia Gavrysh <31997351+OliaG@users.noreply.github.com>
…s.md

Co-authored-by: Olia Gavrysh <31997351+OliaG@users.noreply.github.com>
Co-authored-by: Olia Gavrysh <31997351+OliaG@users.noreply.github.com>
Co-authored-by: Olia Gavrysh <31997351+OliaG@users.noreply.github.com>
@sughosneo
Copy link
Author

Great job! Left e few comments.

Thank you for your feedback @OliaG . I have included all the suggestions.

@sughosneo
Copy link
Author

Hi @IEvangelist, If you could do the final review and approve the changes.

Thank you.

@IEvangelist
Copy link
Member

Hi @IEvangelist David Pine FTE, If you could do the final review and approve the changes.

Thank you.

Hi @sughosneo - there are still suggestions that I've made that have not yet been resolved, either accepted or discussed. Once those are done, feel free to ping me again. Thank you

@IEvangelist
Copy link
Member

Hey @sughosneo when you address this merge conflict, I'll take a look again - should be good to go after that. Thanks

@sughosneo
Copy link
Author

Hey @sughosneo when you address this merge conflict, I'll take a look again - should be good to go after that. Thanks

Thank you @IEvangelist . I have resolved the merge conflict and pushed the latest changes. If you could review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants