Skip to content

Conversation

v-kents
Copy link
Contributor

@v-kents v-kents commented Feb 5, 2021

@BillWagner @tdykstra

Updates for missing/incorrect description metadata.

This is the last of the initial batch of scans - once these are all merged, I'll run another scan to make sure I didn't miss any.

@v-kents v-kents marked this pull request as draft February 11, 2021 17:18
@v-kents v-kents marked this pull request as ready for review February 11, 2021 20:12
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions I'm curious about but nothing blocking.

@tdykstra tdykstra merged commit 2d81a7e into dotnet:master Feb 11, 2021
@v-kents v-kents deleted the fix-desc-09 branch February 12, 2021 17:21
@v-kents
Copy link
Contributor Author

v-kents commented Feb 12, 2021

@tdykstra Thank you for your patience with these. Now that they're all merged, I'll run one last pass to clean up anything missed. Coming soonish (if at all).

@@ -1,4 +1,5 @@
---
description: "Learn more about: Implicit variable '<variablename>' is invalid because of '<message>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still missing the quote

@@ -1,4 +1,5 @@
---
description: "Learn more about: Statement recursively calls the containing 'AddHandler' for event '<eventname>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one as well.

@@ -1,4 +1,5 @@
---
description: "Learn more about: Method '<methodname>' has no parameter named '<parametername>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants