Skip to content

Repo cleanup March '21 #23375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2021
Merged

Repo cleanup March '21 #23375

merged 5 commits into from
Mar 18, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 17, 2021 •
edited
Loading

Contributes to #23124. This PR deals with orphaned articles (delete or add to TOC) and orphaned images.

@dotnet-bot dotnet-bot added this to the March 2021 milestone Mar 17, 2021
Youssef1313
Youssef1313 reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether some of the images (for example upgradereport_plus) should be deleted or not.

While the image isn't used in articles, it's used by the sample.

docs/samples/snippets/csharp/VS_Snippets_CFX/operationbehaviorattribute_impersonation/cs/_upgradereport_files/upgradereport.xslt

Line 185 in ac15aa1

uMe.src = "_UpgradeReport_Files/UpgradeReport_Plus.gif"

I haven't checked the other images, but I expect more to be the same.

BillWagner
BillWagner approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

You can :shipit: when ready.

@gewarren gewarren merged commit 674a877 into dotnet:main Mar 18, 2021
@gewarren gewarren deleted the cleanup-0317 branch March 18, 2021 16:59
@gewarren
Copy link
Contributor Author

Thanks Bill!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@BillWagner BillWagner BillWagner approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard

@tdykstra tdykstra Awaiting requested review from tdykstra

Assignees

No one assigned

Labels

cli/subsvc dotnet-fundamentals/svc dotnet-visualbasic/svc

Projects

None yet

Milestone

March 2021

Development

Successfully merging this pull request may close these issues.

4 participants

@gewarren @BillWagner @Youssef1313 @dotnet-bot