CA1844 #24278
Merged
CA1844 #24278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
May 19, 2021
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Youssef1313
reviewed
May 19, 2021
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Youssef1313
reviewed
May 19, 2021
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
For code analysis rule reference, we usually just have code snippets, not entire samples. However, you could upload the sample to https://github.com/dotnet/samples and then add a link to the full sample from the article. |
22 tasks
gewarren
approved these changes
May 21, 2021
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Youssef1313
added a commit
to Youssef1313/docs
that referenced
this pull request
Jul 5, 2021
* Add ca1844.md * Update ca1844.md * Fix lint errors * Remove trailing spaces * Fix build warnings * Update toc.yml * Update index.md * Update performance-warnings.md * Update performance-warnings.md * Update index.md * Update docs/fundamentals/code-analysis/quality-rules/ca1844.md Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> * Update docs/fundamentals/code-analysis/quality-rules/ca1844.md Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> * Update docs/fundamentals/code-analysis/quality-rules/ca1844.md Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add docs for CA1844: Override Stream ReadAsync/WriteAsync Analyzer
Tracking issue
Quick question: when it comes to providing sample code, is there a limit to how big it should be? In this case, do you want me to provide an entire
Streamsubclass that the user can copy into their editor and compile immediately? I'm more than happy to do that, however it would result in a large amount of boiler-plate code that has nothing to do with the analyzer. Would it be better to just include sample methods without an entire stream class?